Fail fast on language keywords in method names#1235
Conversation
|
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK ΤO ΤESΤ' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged. For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask! |
|
OK TO TEST |
raboof
left a comment
There was a problem hiding this comment.
I agree, nice improvement already!
Oh, cool, this is already in progress in #1236 |
|
Minor issue: Fixed by syncing my fork master branch with |
|
Is Jenkins stuck? |
|
OK TO TEST |
| import Method._ | ||
|
|
||
| require( | ||
| !ReservedWords.contains(name), |
There was a problem hiding this comment.
All scala related fail-fast logic should be removed right?
7c7e529 to
5ca22b3
Compare
|
rebased on latest master. |
References #239
Tested with scripted tests since I haven't found a more suitable place.
This can be a first proposal that provides the user a better error message (it's going to fail the build anyhow).
We can, later on, decide to backtick those keywords in Scala.