Skip to content

Hide import of external types from walkthrough#1260

Merged
ignasi35 merged 1 commit intoakka:masterfrom
ignasi35:remove-timestamp-from-quickstart
Feb 8, 2021
Merged

Hide import of external types from walkthrough#1260
ignasi35 merged 1 commit intoakka:masterfrom
ignasi35:remove-timestamp-from-quickstart

Conversation

@ignasi35
Copy link
Copy Markdown
Contributor

@ignasi35 ignasi35 commented Feb 8, 2021

References #1232

Just hiding it from teh rendered HTML (to not have this change snowball into code changes)

@ignasi35 ignasi35 requested a review from raboof February 8, 2021 14:26
Copy link
Copy Markdown
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this makes things a bit harder to follow though...

Seems like an improvement so 👍 , though let's keep #1232 open until we have cleaned this up? (I guess we can remove the 1.1.0 milestone with this change though)

@ignasi35
Copy link
Copy Markdown
Contributor Author

ignasi35 commented Feb 8, 2021

@raboof I've left a comment on the issue so we can revisit this in the future.

@ignasi35 ignasi35 merged commit 25fb59c into akka:master Feb 8, 2021
@ignasi35 ignasi35 deleted the remove-timestamp-from-quickstart branch February 8, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants