Trim whitespace from multi-value fields (#26)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: aklajnert

changelog.d/minor.a6ea1885.entry.yaml

@@ -0,0 +1,5 @@
+message: Trim whitespace from multi-value fields.
+pr_ids:
+- '26'
+timestamp: 1665243991
+type: minor

changelogd/changelogd.py

@@ -1,9 +1,11 @@
 # -*- coding: utf-8 -*-
 """Main module."""
+import csv
 import datetime
 import getpass
 import glob
 import hashlib
+import io
 import json
 import logging
 import os
@@ -60,7 +62,9 @@ def value(self) -> typing.Any:
             if value is None and not self.required:
                 break
         if value is not None and self.multiple:
-            value = value.split(",")
+            csv_string = io.StringIO(value)
+            reader = csv.reader(csv_string, delimiter=",")
+            value = [value.strip() for value in next(reader)]
         return value
 
 

tests/test_entry.py

@@ -111,6 +111,34 @@ def test_non_interactive_data(setup_env, type_input):
     }
 
 
+def test_multi_value_string(setup_env):
+    runner = CliRunner()
+    runner.invoke(commands.init)
+
+    entry = runner.invoke(
+        commands.entry,
+        ["--type", "1", "--message", "test message"],
+        input='a, b,"c,d", e,f',
+    )
+    assert entry.exit_code == 0
+
+    entries = glob.glob(str(setup_env / "changelog.d" / "*entry.yaml"))
+    assert len(entries) == 1
+
+    with open(entries[0]) as entry_fh:
+        entry_content = yaml.load(entry_fh)
+
+    assert entry_content.pop("timestamp")
+    assert entry_content == {
+        "git_email": "user@example.com",
+        "git_user": "Some User",
+        "issue_id": ["a", "b", "c,d", "e", "f"],
+        "message": "test message",
+        "os_user": "test-user",
+        "type": "feature",
+    }
+
+
 def test_entry_missing_message_types(setup_env, caplog):
     runner = CliRunner()
     runner.invoke(commands.init)