Fix: stack overflow in FindFileInParentDirs on Windows#113
Merged
alajmo merged 3 commits intoalajmo:mainfrom Dec 5, 2025
Merged
Fix: stack overflow in FindFileInParentDirs on Windows#113alajmo merged 3 commits intoalajmo:mainfrom
alajmo merged 3 commits intoalajmo:mainfrom
Conversation
filepath-Dir() returns the same path when already at the filesystem root (eg, C:\), causing infinite recursion. Added check to detect when parentDir equals path, which terminates the recursion properly.
11 tasks
alajmo
reviewed
Dec 5, 2025
alajmo
approved these changes
Dec 5, 2025
Owner
alajmo
left a comment
alajmo
left a comment
There was a problem hiding this comment.
Thanks for catching this bug and fixing it!
Owner
|
This is now released as of 0.31.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112
filepath-Dir() returns the same path when already at the filesystem root (eg, C:), causing infinite recursion.
What's Changed
Added check to detect when parentDir equals path, which terminates the recursion properly.
Technical Description
Root Cause
filepath.Dir()returns the same path when already at filesystem root(e.g.,
C:\), causing infinite recursion.Solution
Added check
if parentDir == pathbefore recursing.