Skip to content

Conversation

@dandelionclock
Copy link
Contributor

@dandelionclock dandelionclock commented Jun 17, 2024

Added icons for climate preset modes and fan modes

Breaking Changes
strings.json and icons.json must be used for adding icons to climate preset and fan modes. Translation keys in these files can only consist of lowercase letters, numbers, and underscore.

  1. Preset modes has to be renamed to ["normal", "defrost", "keep", "dog", "camp"], and
  2. Fan modes has to be renamed to ["off", "bioweapon"].

Please update your scripts and automations after this update.

Fixes issue 725

@dandelionclock dandelionclock marked this pull request as draft June 17, 2024 03:24
@dandelionclock dandelionclock marked this pull request as ready for review June 18, 2024 02:07
@alandtse alandtse changed the title chore: add climate preset icons feat: add climate preset icons Jun 18, 2024
@alandtse
Copy link
Owner

Thanks. Breaking changes refer to changes that impact users. Dev changes aren't breaking.

@alandtse alandtse merged commit 9783fca into alandtse:dev Jun 18, 2024
@dandelionclock
Copy link
Contributor Author

Thanks. Breaking changes refer to changes that impact users. Dev changes aren't breaking.

Although the UI didn't change, the states behind presets are now normal, defrost, keep, dog, and camp. Existing automations and scripts would probably still try to turn preset to "Dog Mode" which will now error out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants