Skip to content
This repository was archived by the owner on Apr 10, 2019. It is now read-only.

Commit bd390c8

Browse files
orivejdnephin
authored andcommitted
Restore the warning about updating vendored linters (#414)
It disappeared in b0bb897 when #320 moved code around: https://github.com/alecthomas/gometalinter/pull/320/files?diff=unified#diff-7ddfb3e035b42cd70649cc33393fe32cR163
1 parent b8bdae8 commit bd390c8

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

main.go

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -241,15 +241,6 @@ func processConfig(config *Config) (include *regexp.Regexp, exclude *regexp.Rege
241241
if !config.EnableGC {
242242
_ = os.Setenv("GOGC", "off")
243243
}
244-
if config.VendoredLinters && config.Install && config.Update {
245-
warning(`Linters are now vendored by default, --update ignored. The original
246-
behaviour can be re-enabled with --no-vendored-linters.
247-
248-
To request an update for a vendored linter file an issue at:
249-
https://github.com/alecthomas/gometalinter/issues/new
250-
`)
251-
config.Update = false
252-
}
253244
// Force sorting by path if checkstyle mode is selected
254245
// !jsonFlag check is required to handle:
255246
// gometalinter --json --checkstyle --sort=severity
@@ -484,6 +475,14 @@ func addGoBinsToPath(gopaths []string) []string {
484475
// configureEnvironmentForInstall sets GOPATH and GOBIN so that vendored linters
485476
// can be installed
486477
func configureEnvironmentForInstall() {
478+
if config.Update {
479+
warning(`Linters are now vendored by default, --update ignored. The original
480+
behaviour can be re-enabled with --no-vendored-linters.
481+
482+
To request an update for a vendored linter file an issue at:
483+
https://github.com/alecthomas/gometalinter/issues/new
484+
`)
485+
}
487486
gopaths := getGoPathList()
488487
vendorRoot := findVendoredLinters()
489488
if vendorRoot == "" {

0 commit comments

Comments
 (0)