Skip to content

Commit 26f6d7d

Browse files
nesitorAndres D. Molins
andauthored
Fix: Remove double ack() method call. (#647)
Co-authored-by: Andres D. Molins <[email protected]>
1 parent 4251795 commit 26f6d7d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/aleph/services/p2p/protocol.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ async def incoming_channel(
3232
peer_id,
3333
)
3434

35-
# we should check the sender here to avoid spam
35+
# We should check the sender here to avoid spam
3636
# and such things...
3737
try:
3838
message_dict = await decode_pubsub_message(message.body)
@@ -42,7 +42,8 @@ async def incoming_channel(
4242
message_dict["item_hash"],
4343
message_dict["signature"],
4444
) in seen_hashes:
45-
await message.ack()
45+
# Messages are already ACKed on underlying implementation in p2p_client.receive_messages()
46+
# if the process don't have issues
4647
continue
4748

4849
seen_hashes.append(

0 commit comments

Comments
 (0)