fix: avoid null values for post_types

Author: gmolki

src/aleph/db/accessors/messages.py

@@ -382,10 +382,14 @@ def get_distinct_post_types_for_address(session: DbSession, address: str) -> lis
         select(MessageDb.content["type"].astext)
         .where(MessageDb.sender == address)
         .where(MessageDb.type == MessageType.post)
+        .where(MessageDb.content["type"].astext.isnot(None))
         .distinct()
         .order_by(MessageDb.content["type"].astext)
     )
-    return list(session.execute(select_stmt).scalars())
+    # Explicitly filter out nulls to keep the return type list[str]
+    return [
+        ptype for ptype in session.execute(select_stmt).scalars() if ptype is not None
+    ]
 
 
 def get_distinct_channels_for_address(session: DbSession, address: str) -> list[str]:

tests/api/test_accounts.py

@@ -103,6 +103,27 @@ def fixture_post_messages_with_types(
             time=now + dt.timedelta(seconds=3),
             channel=Channel("TEST"),
         ),
+        # POST message with null type should be ignored in distinct list
+        MessageDb(
+            item_hash="hash_null_type",
+            chain=Chain.ETH,
+            sender=TEST_ADDRESS,
+            signature="0x" + "0" * 128,
+            item_type=ItemType.inline,
+            type=MessageType.post,
+            item_content='{"address":"'
+            + TEST_ADDRESS
+            + '","time":1652126650.0,"type":null,"content":{"title":"Missing type"}}',
+            content={
+                "address": TEST_ADDRESS,
+                "time": 1652126650.0,
+                "type": None,
+                "content": {"title": "Missing type"},
+            },
+            size=100,
+            time=now + dt.timedelta(seconds=3, milliseconds=500),
+            channel=Channel("TEST"),
+        ),
         # Add a non-POST message to ensure it's filtered out
         MessageDb(
             item_hash="hash5",

tests/db/test_accounts.py

@@ -176,6 +176,25 @@ def fixture_post_messages_for_types():
             time=timestamp_to_datetime(1652126649.5),
             channel=Channel("TEST"),
         ),
+        # POST message with null type should be ignored
+        MessageDb(
+            item_hash="post_hash_null_type",
+            chain=Chain.ETH,
+            sender="0xPostAddress123",
+            signature="0x" + "0" * 128,
+            item_type=ItemType.inline,
+            type=MessageType.post,
+            item_content='{"address":"0xPostAddress123","time":1652126650.0,"type":null,"content":{}}',
+            content={
+                "address": "0xPostAddress123",
+                "time": 1652126650.0,
+                "type": None,
+                "content": {},
+            },
+            size=100,
+            time=timestamp_to_datetime(1652126650.0),
+            channel=Channel("TEST"),
+        ),
         # Non-POST message should be filtered out
         MessageDb(
             item_hash="agg_hash1",