Commit fd53083
committed
osx: Fix a possible segfault in uv__io_poll
In our build infrastructure, I've seen a lot of segfaults recently that were all
only happening on OSX. Upon inspecting the coredumps, it appearded that all
segfaults happened at the same instruction, and upon translating the assembly
back to the source, I found that an array could be indexed with a -1 index
before the index was checked to be not -1.
I'm not 100% sure that this will fix our problems, but this check certainly
appears fishy to me.
XXX: this needs testing1 parent 5e6e6be commit fd53083
1 file changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
171 | | - | |
172 | 170 | | |
173 | 171 | | |
174 | 172 | | |
| 173 | + | |
175 | 174 | | |
176 | 175 | | |
177 | 176 | | |
| |||
0 commit comments