feat(findAnswers): implement the new method #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds searchForAnswers to node / browser (not lite for now) - fix small typo in SearchOptions - add an integration test
PLNech
changed the title
PLNech
approved these changes
Nov 9, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 663adbf:
|
chloelbn
approved these changes
Nov 13, 2020
yannickcr
approved these changes
Nov 13, 2020
eunjae-lee
reviewed
Nov 16, 2020
| const client = algoliasearch(credentials.appId, credentials.apiKey); | ||
|
|
||
| // TODO: remove this customization once the engine accepts url encoded query params | ||
| client.transporter.userAgent.value = "answers-test"; |
There was a problem hiding this comment.
@Haroenv to be clear, are we waiting for the engine fix, so that we can get rid of this line before merging this PR?
There was a problem hiding this comment.
Hey @eunjae-lee, the engine fix won't be happening soon, so I'd rather merge this and prepare a v1.1 PR for when the engine has catched up :)
There was a problem hiding this comment.
got it. thanks for clarification!
This was referenced Mar 10, 2021
Closed
Closed
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.