feat(analytics-reco): allow creation of clients with their own credentials #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
commented
Nov 10, 2020
Comment on lines
+11
to
+15
| export type OptionalCredentials<TClientOptions extends Credentials> = Omit< | ||
| TClientOptions, | ||
| keyof Credentials | ||
| > & | ||
| Pick<Partial<TClientOptions>, keyof Credentials>; |
There was a problem hiding this comment.
if someone can find a cleaner way to implement this, I'm all ears
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0156372:
|
Merged
eunjae-lee
approved these changes
Nov 16, 2020
This was referenced Mar 10, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/algolia/algoliasearch-client-specs-internal/issues/144
This actually didn't need to change any code, just the types, since they didn't allow appId & apiKey, while they actually are passed along already