Skip to content

Commit 0839201

Browse files
authored
fix: include contribution types in commit message (#414)
1 parent 89dbc86 commit 0839201

2 files changed

Lines changed: 12 additions & 7 deletions

File tree

lib/add-contributor.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,15 @@ async function addContributor({
5353
originalSha: config.getOriginalSha(),
5454
};
5555

56+
const contributionsTitlePartLimit = 3
57+
const arr = contributions.slice(0, contributionsTitlePartLimit);
58+
if (arr.length > contributionsTitlePartLimit) arr[arr.length - 1] = `${contributions.length - 2} more`
59+
const contributionsTitlePartText = arr.slice(0, arr.length - 1).join(', ') + ", and " + arr.slice(-1);
60+
5661
const convention = config.get().commitConvention;
5762
const prTitle = convertMessage({
5863
tag: "docs",
59-
msg: `add ${who} as a contributor`,
64+
msg: `add ${who} as a contributor for ${contributionsTitlePartText}`,
6065
convention
6166
});
6267

test/integration/__snapshots__/issue_comment.test.js.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ Object {
444444
This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
445445
"head": "all-contributors/add-jakebolam",
446446
"maintainer_can_modify": true,
447-
"title": "add jakebolam as a contributor",
447+
"title": "add jakebolam as a contributor for code, doc, and infra",
448448
}
449449
`;
450450
@@ -513,7 +513,7 @@ Object {
513513
This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
514514
"head": "all-contributors/add-jakebolam",
515515
"maintainer_can_modify": true,
516-
"title": "add jakebolam as a contributor",
516+
"title": "add jakebolam as a contributor for code, doc, and infra",
517517
}
518518
`;
519519
@@ -588,7 +588,7 @@ Object {
588588
This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
589589
"head": "all-contributors/add-jakebolam",
590590
"maintainer_can_modify": true,
591-
"title": "docs: add jakebolam as a contributor",
591+
"title": "docs: add jakebolam as a contributor for code, doc, and infra",
592592
}
593593
`;
594594
@@ -664,7 +664,7 @@ Object {
664664
This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
665665
"head": "all-contributors/add-jakebolam",
666666
"maintainer_can_modify": true,
667-
"title": "add jakebolam as a contributor",
667+
"title": "add jakebolam as a contributor for code, doc, and infra",
668668
}
669669
`;
670670
@@ -772,7 +772,7 @@ Object {
772772
This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
773773
"head": "all-contributors/add-jakebolam",
774774
"maintainer_can_modify": true,
775-
"title": "add jakebolam as a contributor",
775+
"title": "add jakebolam as a contributor for code, doc, and infra",
776776
}
777777
`;
778778
@@ -869,7 +869,7 @@ Object {
869869
This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
870870
"head": "all-contributors/add-jakebolam",
871871
"maintainer_can_modify": true,
872-
"title": "add jakebolam as a contributor",
872+
"title": "add jakebolam as a contributor for code, doc, and infra",
873873
}
874874
`;
875875

0 commit comments

Comments
 (0)