fix: resolve invalid link for profile (#421)

Author: tenshiAMD

lib/get-user-details.js

@@ -1,6 +1,7 @@
 module.exports = getUserDetails;
 
 const { UserNotFoundError } = require("./modules/errors");
+const { generateValidLink } = require("./modules/helpers");
 
 async function getUserDetails({ octokit, username }) {
   // TODO: optimization, if commenting user is the user we're adding we can avoid an api call
@@ -32,6 +33,6 @@ async function getUserDetails({ octokit, username }) {
     login,
     name: name || username,
     avatar_url,
-    profile: blog || html_url,
+    profile: generateValidLink(blog || html_url, username),
   };
 }

lib/modules/helpers.js

@@ -0,0 +1,13 @@
+function generateValidLink(url, username = '') {
+  let validLink = url
+  const validRegex = /^https?:\/\/(?:www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b(?:[-a-zA-Z0-9()@:%_\+.~#?&\/=]*)$/
+
+  if (!validLink.startsWith("http")) validLink = `http://${url}/`
+  if (!validLink.match(validRegex)) validLink = `https://github.com/${username}/`
+
+  return validLink
+}
+
+module.exports = {
+  generateValidLink
+}

test/unit/helpers.test.js

@@ -0,0 +1,19 @@
+const { generateValidLink } = require('../../lib/modules/helpers');
+
+describe('generateValidLink', () => {
+  const username = 'tenshiAMD'
+
+  test('return valid link - no protocol', async () => {
+    let url = 'tenshiamd.com';
+    let validUrl = generateValidLink(url, username);
+
+    expect(validUrl).toEqual(`http://${url}/`);
+  });
+
+  test('return valid link - incomplete URL format', async () => {
+    let url = 'contributor';
+    let validUrl = generateValidLink(url, username);
+
+    expect(validUrl).toEqual(`https://github.com/${username}/`);
+  });
+});