fix: only comment about no contributions after checking all contributors#489
Merged
gr2m merged 2 commits intoSep 12, 2024
Merged
Conversation
|
@JoshuaKGoldberg is attempting to deploy a commit to the All Contributors Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gr2m
reviewed
Sep 12, 2024
| "updated_at": "2019-01-10T08:36:52Z", | ||
| "author_association": "MEMBER", | ||
| "body": "@all-contributors please add jakebolam for code, doc and infra" | ||
| "body": "@all-contributors please add jakebolam for code, doc and infra\n🤖 Beep boop! This comment was added automatically by [all-contributors-auto-action](https://github.com/marketplace/actions/all-contributors-auto-action).\nNot all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.\n...and of course, thank you for contributing! 💙" |
Contributor
There was a problem hiding this comment.
I don't quite get this change, that does not look like a comment that a user would post?
Contributor
Author
There was a problem hiding this comment.
It's a comment a bot of mine posts that hits the issue. 🙂
Example: JoshuaKGoldberg/create-typescript-app#429 (comment)
Contributor
There was a problem hiding this comment.
ohhh never seen this action! Cool!
|
🎉 This PR is included in version 1.19.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
Author
|
Hooray! Thanks @gr2m! |
theomart77
approved these changes
Nov 6, 2025
3 tasks
lwasser
added a commit
that referenced
this pull request
Jan 23, 2026
…odecov action (#544) <!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated! Please make sure that you are familiar with and follow the [Code of Conduct](https://allcontributors.org/docs/en/project/code-of-conduct) for this project. Also, please make sure you're familiar with and follow the instructions in the [contributing guidelines](https://github.com/all-contributors/all-contributors/blob/master/CONTRIBUTING.md) (found in the CONTRIBUTING.md file). If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request Please fill out the information below to expedite the review and (hopefully) merge of your pull request! --> <!-- What changes are being made? (What feature/bug is being fixed here?) e.g. Fixes #375 Check this [list](https://help.github.com/en/articles/closing-issues-using-keywords) of valid keywords. --> **What**: Fixes #530 <!-- Why are these changes necessary? --> **Why**: Identified that the cause of the testcase failures were from PR #489, to address #468 , as it introduced a small logical error and also added a new testcase for the identified bug without updating the test snapshots. <!-- How were these changes implemented? --> **How**: 1. Use of the logical bug `pullCreated ||= await triggerActionAdd(...);` within the `for` loop caused it to short circuit after the first contributor, as `pullCreated` is set to True after including the first contributor, and short circuit for subsequent iterations in the loop (causing it to not add subsequent contributors in the list). * Fixed the bug accordingly to not short-circuit 3. Testcase snapshot outdated due to added case to account for the bug identified in the PR 4. Testcase snapshot oudated due to change in logging from that PR i.e. `log.info(`No contributions for ${who}`);` Testcases were tested on Node v22.22.0 (LTS) Additionally, update codecov workflow to use `codecov-action` instead of deprecated codecov npm package (v3.8.3), see [codecov npm](https://www.npmjs.com/package/codecov?activeTab=readme ) which is no longer functioning correctly in the CI environment. <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [ ] Documentation - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table. <!-- this is optional, see the contributing guidelines for instructions --> [Bot Usage](https://allcontributors.org/docs/en/bot/installation#4-update-your-contributing-documentation) <!-- feel free to add additional comments --> --------- Co-authored-by: Leah Wasser <leah@pyopensci.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fixes #468.
Why: Currently, the bot comments "I couldn't determine ..." as soon as a potential contributor is found to not have any contributions. But if there are multiple potential contributors, that comment shouldn't happen.
How: With these changes, the comment is only added after all potential contributors are checked for sending a PR.
Checklist:
[ ] Added myself to contributors table.