Skip to content

Commit 0fac96e

Browse files
masneybjic23
authored andcommitted
staging: iio: isl29028: only set ALS scale when ALS/IR sensing is enabled
isl29028_chip_init_and_power_on() calls isl29028_set_als_scale() and this is not needed until the user actually needs to take a reading from the ALS/IR sensor. This patch moves the isl29028_set_als_scale() call from isl29028_chip_init_and_power_on() to isl29028_set_als_ir_mode(). This sets the stage for faster resume times from runtime power management if the user is only querying the proximity sensor. Signed-off-by: Brian Masney <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 84a7669 commit 0fac96e

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/staging/iio/light/isl29028.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,15 @@ static int isl29028_set_als_scale(struct isl29028_chip *chip, int lux_scale)
146146
static int isl29028_set_als_ir_mode(struct isl29028_chip *chip,
147147
enum isl29028_als_ir_mode mode)
148148
{
149-
int ret = 0;
149+
int ret;
150150

151151
if (chip->als_ir_mode == mode)
152152
return 0;
153153

154+
ret = isl29028_set_als_scale(chip, chip->lux_scale);
155+
if (ret < 0)
156+
return ret;
157+
154158
switch (mode) {
155159
case ISL29028_MODE_ALS:
156160
ret = regmap_update_bits(chip->regmap, ISL29028_REG_CONFIGURE,
@@ -453,7 +457,7 @@ static int isl29028_chip_init_and_power_on(struct isl29028_chip *chip)
453457
return ret;
454458
}
455459

456-
return isl29028_set_als_scale(chip, chip->lux_scale);
460+
return ret;
457461
}
458462

459463
static bool isl29028_is_volatile_reg(struct device *dev, unsigned int reg)

0 commit comments

Comments
 (0)