Skip to content

Commit c5c7502

Browse files
Yang Yinglianghdeller
authored andcommitted
video: fbdev: imxfb: fix return value check in imxfb_probe()
If devm_ioremap_resource() fails, it never return NULL, replace NULL test with IS_ERR(). Fixes: b083c22 ("video: fbdev: imxfb: Convert request_mem_region + ioremap to devm_ioremap_resource") Signed-off-by: Yang Yingliang <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent 3eb8fcc commit c5c7502

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/video/fbdev/imxfb.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -971,9 +971,9 @@ static int imxfb_probe(struct platform_device *pdev)
971971
}
972972

973973
fbi->regs = devm_ioremap_resource(&pdev->dev, res);
974-
if (fbi->regs == NULL) {
974+
if (IS_ERR(fbi->regs)) {
975975
dev_err(&pdev->dev, "Cannot map frame buffer registers\n");
976-
ret = -ENOMEM;
976+
ret = PTR_ERR(fbi->regs);
977977
goto failed_ioremap;
978978
}
979979

0 commit comments

Comments
 (0)