Skip to content

Commit 35b6cbd

Browse files
tedwu13Ted Wu
and
Ted Wu
authored
Add inline documentation to document that Orchestrator will revert if any transaction fails (#203)
Co-authored-by: Ted Wu <[email protected]>
1 parent 212d341 commit 35b6cbd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

contracts/Orchestrator.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ contract Orchestrator is Ownable {
3636
* The Orchestrator calls rebase on the policy and notifies downstream applications.
3737
* Contracts are guarded from calling, to avoid flash loan attacks on liquidity
3838
* providers.
39-
* If a transaction in the transaction list reverts, it is swallowed and the remaining
40-
* transactions are executed.
39+
* If a transaction in the transaction list fails, Orchestrator will stop execution
40+
* and revert to prevent a gas underprice attack.
4141
*/
4242
function rebase() external {
4343
require(msg.sender == tx.origin); // solhint-disable-line avoid-tx-origin

0 commit comments

Comments
 (0)