Code review comments

Ted Wu · Ted Wu · commit 8e0f30c50797 · 2021-02-19T10:26:17.000-08:00
diff --git a/contracts/Orchestrator.sol b/contracts/Orchestrator.sol
@@ -47,9 +47,8 @@ contract Orchestrator is Ownable {
         for (uint256 i = 0; i < transactions.length; i++) {
             Transaction storage t = transactions[i];
             if (t.enabled) {
-                (bool result, bytes memory reason) = t.destination.call(t.data);
+                (bool result, ) = t.destination.call(t.data);
                 if (!result) {
-                    emit TransactionFailed(t.destination, i, t.data);
                     revert("Transaction Failed");
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,8 @@ contract Orchestrator is Ownable {`
`47`	`47`	`for (uint256 i = 0; i < transactions.length; i++) {`
`48`	`48`	`Transaction storage t = transactions[i];`
`49`	`49`	`if (t.enabled) {`
`50`		`- (bool result, bytes memory reason) = t.destination.call(t.data);`
	`50`	`+ (bool result, ) = t.destination.call(t.data);`
`51`	`51`	`if (!result) {`
`52`		`- emit TransactionFailed(t.destination, i, t.data);`
`53`	`52`	`revert("Transaction Failed");`
`54`	`53`	`}`
`55`	`54`	`}`