Skip to content

Commit d03cd68

Browse files
sojingleclaude
andcommitted
chore: remove Package.resolved and fix deprecated init ambiguity
Add Package.resolved to .gitignore (library packages should not pin resolved versions). Remove default value from deprecated blocklist parameter to avoid overload ambiguity with the new excludelist init. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ce17b58 commit d03cd68

4 files changed

Lines changed: 4 additions & 26 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ DerivedData/
77
.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
88
.netrc
99
node_modules/
10+
Package.resolved

Package.resolved

Lines changed: 0 additions & 23 deletions
This file was deleted.

Sources/Amplitude/Plugins/NetworkTrackingPlugin.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public struct NetworkTrackingOptions {
9191
}
9292

9393
@available(*, deprecated, renamed: "init(allowlist:excludelist:)", message: "Deprecated, use 'excludelist' instead")
94-
public init(allowlist: [String], blocklist: [String] = []) {
94+
public init(allowlist: [String], blocklist: [String]) {
9595
self.allowlist = allowlist
9696
self.excludelist = blocklist
9797
}

Tests/AmplitudeTests/Plugins/NetworkTrackingPluginTest.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1061,8 +1061,8 @@ final class NetworkTrackingPluginTest: XCTestCase {
10611061
responseHeaders: NetworkTrackingOptions.CaptureHeader(),
10621062
requestBody: nil, // GET requests typically don't have body
10631063
responseBody: NetworkTrackingOptions.CaptureBody(
1064-
allowlist: ["products", "total"],
1065-
blocklist: ["internal_metadata"]
1064+
allowlist: ["products/**", "total"],
1065+
excludelist: ["internal_metadata"]
10661066
)
10671067
)
10681068
]

0 commit comments

Comments
 (0)