Skip to content

Commit 2068db5

Browse files
committed
ipmi: Cleanup oops on initialization failure
Commit 93c303d "ipmi_si: Clean up shutdown a bit" didn't copy the behavior of the cleanup in one spot, it needed to check for a non-NULL interface before cleaning it up. Reported-by: Meelis Roos <[email protected]> Signed-off-by: Corey Minyard <[email protected]> Tested-by: Meelis Roos <[email protected]>
1 parent 9ffc59d commit 2068db5

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/char/ipmi/ipmi_si_intf.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2088,8 +2088,10 @@ static int try_smi_init(struct smi_info *new_smi)
20882088
return 0;
20892089

20902090
out_err:
2091-
ipmi_unregister_smi(new_smi->intf);
2092-
new_smi->intf = NULL;
2091+
if (new_smi->intf) {
2092+
ipmi_unregister_smi(new_smi->intf);
2093+
new_smi->intf = NULL;
2094+
}
20932095

20942096
kfree(init_name);
20952097

0 commit comments

Comments
 (0)