Skip to content

reserved identifier violation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elfring opened this issue May 20, 2016 · 3 comments
Open

reserved identifier violation #23

elfring opened this issue May 20, 2016 · 3 comments
Milestone

Comments

@elfring
Copy link

elfring commented May 20, 2016

I would like to point out that identifiers like "__LIBUI_UI_UNIX_H__" and "_UI_EXTERN" do eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@andlabs
Copy link
Owner

andlabs commented May 20, 2016

Yes, there's always a risk when anyone uses _ at the beginning of a name for the private namespace. I suppose I could use a different prefix like UI_I_ or something like that; not sure.

@elfring
Copy link
Author

elfring commented May 3, 2018

How do you think about to avoid that this software depends on undefined behaviour?

@andlabs
Copy link
Owner

andlabs commented May 3, 2018

I chose uipriv as a prefix. No ETA on changing existing things (especially since I need to go back and find the ones not in ui.h); that will be last in #308 though (which is basically a mass renaming project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants