Skip to content

Commit 2a6b015

Browse files
authored
Skip Xcode install on mac_mokey Android tests (#163685)
These tests are failing on querying Xcode for simulator devices when running Android tests. Ideally recipes wouldn't try to install Xcode unless requested via `"sdk_version": "[xcode version number]"` property, [but they do](flutter/flutter#163670). Since the recipe[ mapping of macOS version to Xcode version](https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/osx_sdk/api.py#22) is out of date, it's falling back to an old version of Xcode when none are specified. Stop installing Xcode on these builder configurations. If this works I'll follow up and add it to `mac_pixel_7pro`, `mac_arm64_android`, etc. First step of flutter/flutter#161655. If this works `bringup` can be removed. Fixes flutter/flutter#163309 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 5ce2ad9 commit 2a6b015

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

.ci.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,10 @@ platform_properties:
252252
os: Mac-13|Mac-14
253253
cpu: x86
254254
device_type: "mokey"
255+
$flutter/osx_sdk : >-
256+
{
257+
"skip_xcode_install": true
258+
}
255259
mac_arm64_mokey:
256260
properties:
257261
dependencies: >-
@@ -262,6 +266,10 @@ platform_properties:
262266
os: Mac-13|Mac-14
263267
cpu: arm64
264268
device_type: "mokey"
269+
$flutter/osx_sdk : >-
270+
{
271+
"skip_xcode_install": true
272+
}
265273
266274
mac_pixel_7pro:
267275
properties:

0 commit comments

Comments
 (0)