Skip to content

Commit 1188e35

Browse files
clydinfilipesilva
authored andcommitted
refactor(@angular-devkit/build-angular): minor CSS processing cleanup
1 parent 1080357 commit 1188e35

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/angular_devkit/build_angular/src/angular-cli-files/plugins/cleancss-webpack-plugin.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
* found in the LICENSE file at https://angular.io/license
1010
*/
1111

12-
import { Compiler } from 'webpack';
13-
import { RawSource, SourceMapSource } from 'webpack-sources';
12+
import { Compiler, compilation } from 'webpack';
13+
import { RawSource, Source, SourceMapSource } from 'webpack-sources';
1414

1515
const CleanCSS = require('clean-css');
1616

@@ -60,7 +60,7 @@ export class CleanCssWebpackPlugin {
6060
}
6161

6262
apply(compiler: Compiler): void {
63-
hook(compiler, (compilation: any, chunks: Array<Chunk>) => {
63+
hook(compiler, (compilation: compilation.Compilation, chunks: Array<Chunk>) => {
6464
const cleancss = new CleanCSS({
6565
compatibility: 'ie9',
6666
level: 2,
@@ -80,7 +80,7 @@ export class CleanCssWebpackPlugin {
8080
const actions = files
8181
.filter(file => this._options.test(file))
8282
.map(file => {
83-
const asset = compilation.assets[file];
83+
const asset = compilation.assets[file] as Source;
8484
if (!asset) {
8585
return Promise.resolve();
8686
}
@@ -100,7 +100,7 @@ export class CleanCssWebpackPlugin {
100100
}
101101

102102
return Promise.resolve()
103-
.then(() => cleancss.minify(content, map))
103+
.then(() => map ? cleancss.minify(content, map) : cleancss.minify(content))
104104
.then((output: any) => {
105105
let hasWarnings = false;
106106
if (output.warnings && output.warnings.length > 0) {

packages/angular_devkit/build_angular/src/angular-cli-files/plugins/raw-css-loader.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
export default function(content: string, map: object) {
1010
const stringifiedContent = JSON.stringify(content);
11-
const stringifiedMap = map && JSON.stringify(map);
11+
const stringifiedMap = map ? JSON.stringify(map) : `''`;
1212

1313
return `module.exports = [[module.id, ${stringifiedContent}, '', ${stringifiedMap}]]`;
1414
}

0 commit comments

Comments
 (0)