build: remove module_name and module_root

alan-agius4 · clydin · commit 1227a2c84f12 · 2020-05-11T07:45:58.000-04:00
Since we are importing the vendored typescript with relative imports, module_name and module_root in the its ts_library are not needed. See: #17670 (comment) for more context
diff --git a/packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/BUILD.bazel b/packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/BUILD.bazel
@@ -8,7 +8,5 @@ ts_library(
     name = "TypeScript",
     srcs = ["lib/typescript.d.ts"],
     data = ["lib/typescript.js"],
-    module_name = "typescript",
-    module_root = "lib/typescript.d.ts",
     visibility = ["//packages/schematics/angular:__subpackages__"],
 )

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,5 @@ ts_library(`
`8`	`8`	`name = "TypeScript",`
`9`	`9`	`srcs = ["lib/typescript.d.ts"],`
`10`	`10`	`data = ["lib/typescript.js"],`
`11`		`- module_name = "typescript",`
`12`		`- module_root = "lib/typescript.d.ts",`
`13`	`11`	`visibility = ["//packages/schematics/angular:__subpackages__"],`
`14`	`12`	`)`