Skip to content

Commit 1c2aeeb

Browse files
alan-agius4filipesilva
authored andcommitted
refactor(@angular-devkit/build-angular): remove view engine app-shell generation
BREAKING CHANGE: App-shell builder now only supports generation using Ivy
1 parent 14c8a09 commit 1c2aeeb

File tree

1 file changed

+3
-12
lines changed
  • packages/angular_devkit/build_angular/src/app-shell

1 file changed

+3
-12
lines changed

packages/angular_devkit/build_angular/src/app-shell/index.ts

+3-12
Original file line numberDiff line numberDiff line change
@@ -72,21 +72,12 @@ async function _renderUniversal(
7272

7373
const {
7474
AppServerModule,
75-
AppServerModuleNgFactory,
7675
renderModule,
77-
renderModuleFactory,
7876
} = await import(serverBundlePath);
7977

80-
let renderModuleFn: (module: unknown, options: {}) => Promise<string>;
81-
let AppServerModuleDef: unknown;
78+
const renderModuleFn: ((module: unknown, options: {}) => Promise<string>) | undefined = renderModule;
8279

83-
if (renderModuleFactory && AppServerModuleNgFactory) {
84-
renderModuleFn = renderModuleFactory;
85-
AppServerModuleDef = AppServerModuleNgFactory;
86-
} else if (renderModule && AppServerModule) {
87-
renderModuleFn = renderModule;
88-
AppServerModuleDef = AppServerModule;
89-
} else {
80+
if (!(renderModuleFn && AppServerModule)) {
9081
throw new Error(`renderModule method and/or AppServerModule were not exported from: ${serverBundlePath}.`);
9182
}
9283

@@ -96,7 +87,7 @@ async function _renderUniversal(
9687
url: options.route,
9788
};
9889

99-
let html = await renderModuleFn(AppServerModuleDef, renderOpts);
90+
let html = await renderModuleFn(AppServerModule, renderOpts);
10091
// Overwrite the client index file.
10192
const outputIndexPath = options.outputIndexPath
10293
? path.join(root, options.outputIndexPath)

0 commit comments

Comments
 (0)