Skip to content

Commit 29cf812

Browse files
cexbrayatalan-agius4
authored andcommitted
fix(@schematics/angular): remove jasmine-spec-reporter and ts-node from default workspace
The dependencies are only needed for protractor tests, so they should only be added by the e2e schematics.
1 parent 48701a9 commit 29cf812

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

packages/schematics/angular/e2e/index.ts

+10-2
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,19 @@ export default function (options: E2eOptions): Rule {
7474
}),
7575
move(root),
7676
])),
77-
host => addPackageJsonDependency(host, {
77+
host => [{
7878
type: NodeDependencyType.Dev,
7979
name: 'protractor',
8080
version: '~7.0.0',
81-
}),
81+
}, {
82+
type: NodeDependencyType.Dev,
83+
name: 'jasmine-spec-reporter',
84+
version: '~7.0.0',
85+
}, {
86+
type: NodeDependencyType.Dev,
87+
name: 'ts-node',
88+
version: '~9.1.1',
89+
}].forEach(dep => addPackageJsonDependency(host, dep)),
8290
addScriptsToPackageJson(),
8391
]);
8492
};

packages/schematics/angular/workspace/files/package.json.template

+1-3
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,11 @@
2929
"@types/jasmine": "~3.6.0",<% } %>
3030
"@types/node": "^12.11.1",<% if (!minimal) { %>
3131
"jasmine-core": "~3.7.0",
32-
"jasmine-spec-reporter": "~7.0.0",
3332
"karma": "~6.3.0",
3433
"karma-chrome-launcher": "~3.1.0",
3534
"karma-coverage": "~2.0.3",
3635
"karma-jasmine": "~4.0.0",
37-
"karma-jasmine-html-reporter": "^1.5.0",
38-
"ts-node": "~9.1.1",<% } %>
36+
"karma-jasmine-html-reporter": "^1.5.0",<% } %>
3937
"typescript": "<%= latestVersions.TypeScript %>"
4038
}
4139
}

0 commit comments

Comments
 (0)