fixup: comments from PR

hansl · hansl · commit 908fa688ddf9 · 2018-12-10T10:20:21.000-08:00
diff --git a/packages/schematics/update/update/index.ts b/packages/schematics/update/update/index.ts
@@ -380,12 +380,12 @@ function _getUpdateMetadata(
         `packageGroup metadata of package ${packageJson.name} is malformed. Ignoring.`,
       );
     }
+
+    result.packageGroupName = Object.keys(result.packageGroup)[0];
   }
 
   if (typeof metadata['packageGroupName'] == 'string') {
     result.packageGroupName = metadata['packageGroupName'];
-  } else {
-    result.packageGroupName = Object.keys(result.packageGroup)[0];
   }
 
   if (metadata['requirements']) {

Original file line number	Diff line number	Diff line change
`@@ -380,12 +380,12 @@ function _getUpdateMetadata(`
`380`	`380`	`packageGroup metadata of package ${packageJson.name} is malformed. Ignoring.`,
`381`	`381`	`);`
`382`	`382`	`}`
	`383`	`+`
	`384`	`+ result.packageGroupName = Object.keys(result.packageGroup)[0];`
`383`	`385`	`}`
`384`	`386`
`385`	`387`	`if (typeof metadata['packageGroupName'] == 'string') {`
`386`	`388`	`result.packageGroupName = metadata['packageGroupName'];`
`387`		`- } else {`
`388`		`- result.packageGroupName = Object.keys(result.packageGroup)[0];`
`389`	`389`	`}`
`390`	`390`
`391`	`391`	`if (metadata['requirements']) {`