Skip to content

Commit d3c7892

Browse files
committed
test: disable lazy routing string format tests
The new Ivy-only Webpack plugin no longer supports the deprecate string format for lazy routes.
1 parent 7f9fc39 commit d3c7892

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

packages/angular_devkit/build_angular/src/browser/specs/lazy-module_spec.ts

+12
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,12 @@ describe('Browser Builder lazy modules', () => {
6060
for (const [name, imports] of cases) {
6161
describe(`Load children ${name} syntax`, () => {
6262
it('supports lazy bundle for lazy routes with JIT', async () => {
63+
if (name === 'string' && !veEnabled) {
64+
pending('Does not apply to Ivy.');
65+
66+
return;
67+
}
68+
6369
host.writeMultipleFiles(lazyModuleFiles);
6470
host.writeMultipleFiles(imports);
6571

@@ -72,6 +78,12 @@ describe('Browser Builder lazy modules', () => {
7278
});
7379

7480
it('supports lazy bundle for lazy routes with AOT', async () => {
81+
if (name === 'string' && !veEnabled) {
82+
pending('Does not apply to Ivy.');
83+
84+
return;
85+
}
86+
7587
host.writeMultipleFiles(lazyModuleFiles);
7688
host.writeMultipleFiles(imports);
7789
addLazyLoadedModulesInTsConfig(host, lazyModuleFiles);

tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,13 @@ export default async function () {
8686
await ng('e2e');
8787
await ng('e2e', '--prod');
8888

89+
if (!(getGlobalVariable('argv')['ve'])) {
90+
// Only applicable to VE. Does not apply to Ivy.
91+
return;
92+
}
93+
8994
// Test string import.
90-
// Both Ivy and View Engine should support it.
95+
// View Engine should support it.
9196
await updateJsonFile('tsconfig.app.json', tsConfig => {
9297
tsConfig.files.push('src/app/lazy/lazy.module.ts');
9398
});

0 commit comments

Comments
 (0)