perf(@angular/cli): cache root manifest and resolve restricted package exports in ng add

This change enhances the `ng add` command's performance by caching the root project manifest (`package.json`) to avoid redundant disk reads and JSON parsing during peer dependency conflict checks.

Additionally, it improves the robustness of `package.json` resolution for installed packages. Previously, resolving `package.json` could fail if a third-party package used the Node.js `"exports"` field without explicitly exporting its `package.json`. The CLI now correctly handles this by falling back to resolving the package's entry point and traversing upwards to find the manifest.

Author: clydin

packages/angular/cli/src/commands/add/cli.ts

@@ -8,9 +8,10 @@
 
 import { Listr, ListrRenderer, ListrTaskWrapper, color, figures } from 'listr2';
 import assert from 'node:assert';
+import { existsSync } from 'node:fs';
 import fs from 'node:fs/promises';
 import { createRequire } from 'node:module';
-import { dirname, join } from 'node:path';
+import { basename, dirname, join } from 'node:path';
 import npa from 'npm-package-arg';
 import semver, { Range, compare, intersects, prerelease, satisfies, valid } from 'semver';
 import { Argv } from 'yargs';
@@ -30,6 +31,7 @@ import {
   PackageMetadata,
 } from '../../package-managers';
 import { assertIsError } from '../../utilities/error';
+import { findUpSync } from '../../utilities/find-up';
 import { isTTY } from '../../utilities/tty';
 import { VERSION } from '../../utilities/version';
 
@@ -107,6 +109,7 @@ export default class AddCommandModule
   private readonly schematicName = 'ng-add';
   private rootRequire = createRequire(this.context.root + '/');
   #projectVersionCache = new Map<string, string | null>();
+  #rootManifestCache: PackageManifest | null = null;
 
   override async builder(argv: Argv): Promise<Argv<AddCommandArgs>> {
     const localYargs = (await super.builder(argv))
@@ -156,6 +159,7 @@ export default class AddCommandModule
 
   async run(options: Options<AddCommandArgs> & OtherOptions): Promise<number | void> {
     this.#projectVersionCache.clear();
+    this.#rootManifestCache = null;
     const { logger } = this.context;
     const { collection, skipConfirmation } = options;
 
@@ -657,18 +661,7 @@ export default class AddCommandModule
   }
 
   private isPackageInstalled(name: string): boolean {
-    try {
-      this.rootRequire.resolve(join(name, 'package.json'));
-
-      return true;
-    } catch (e) {
-      assertIsError(e);
-      if (e.code !== 'MODULE_NOT_FOUND') {
-        throw e;
-      }
-    }
-
-    return false;
+    return !!this.resolvePackageJson(name);
   }
 
   private executeSchematic(
@@ -707,12 +700,7 @@ export default class AddCommandModule
       return cachedVersion;
     }
 
-    const { root } = this.context;
-    let installedPackagePath;
-    try {
-      installedPackagePath = this.rootRequire.resolve(join(name, 'package.json'));
-    } catch {}
-
+    const installedPackagePath = this.resolvePackageJson(name);
     if (installedPackagePath) {
       try {
         const installedPackage = JSON.parse(
@@ -724,13 +712,7 @@ export default class AddCommandModule
       } catch {}
     }
 
-    let projectManifest;
-    try {
-      projectManifest = JSON.parse(
-        await fs.readFile(join(root, 'package.json'), 'utf-8'),
-      ) as PackageManifest;
-    } catch {}
-
+    const projectManifest = await this.getProjectManifest();
     if (projectManifest) {
       const version =
         projectManifest.dependencies?.[name] || projectManifest.devDependencies?.[name];
@@ -746,6 +728,53 @@ export default class AddCommandModule
     return null;
   }
 
+  private async getProjectManifest(): Promise<PackageManifest | null> {
+    if (this.#rootManifestCache) {
+      return this.#rootManifestCache;
+    }
+
+    const { root } = this.context;
+    try {
+      this.#rootManifestCache = JSON.parse(
+        await fs.readFile(join(root, 'package.json'), 'utf-8'),
+      ) as PackageManifest;
+
+      return this.#rootManifestCache;
+    } catch {
+      return null;
+    }
+  }
+
+  private resolvePackageJson(name: string): string | undefined {
+    try {
+      return this.rootRequire.resolve(join(name, 'package.json'));
+    } catch (e) {
+      assertIsError(e);
+      if (e.code === 'ERR_PACKAGE_PATH_NOT_EXPORTED') {
+        try {
+          const mainPath = this.rootRequire.resolve(name);
+          let directory = dirname(mainPath);
+
+          // Stop at the node_modules boundary or the root of the file system
+          while (directory && basename(directory) !== 'node_modules') {
+            const packageJsonPath = join(directory, 'package.json');
+            if (existsSync(packageJsonPath)) {
+              return packageJsonPath;
+            }
+
+            const parent = dirname(directory);
+            if (parent === directory) {
+              break;
+            }
+            directory = parent;
+          }
+        } catch {}
+      }
+    }
+
+    return undefined;
+  }
+
   private async getPeerDependencyConflicts(manifest: PackageManifest): Promise<string[] | false> {
     if (!manifest.peerDependencies) {
       return false;