Skip to content

Commit f8fac8f

Browse files
committed
test(@angular-devkit/build-angular): disable lazy routing string format tests
The new Ivy-only Webpack plugin no longer supports the deprecate string format for lazy routes.
1 parent 5d34f21 commit f8fac8f

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

packages/angular_devkit/build_angular/src/browser/specs/lazy-module_spec.ts

+12
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,12 @@ describe('Browser Builder lazy modules', () => {
6161
for (const [name, imports] of cases) {
6262
describe(`Load children ${name} syntax`, () => {
6363
it('supports lazy bundle for lazy routes with JIT', async () => {
64+
if (name === 'string' && !veEnabled) {
65+
pending('Does not apply to Ivy.');
66+
67+
return;
68+
}
69+
6470
host.writeMultipleFiles(lazyModuleFiles);
6571
host.writeMultipleFiles(imports);
6672

@@ -73,6 +79,12 @@ describe('Browser Builder lazy modules', () => {
7379
});
7480

7581
it('supports lazy bundle for lazy routes with AOT', async () => {
82+
if (name === 'string' && !veEnabled) {
83+
pending('Does not apply to Ivy.');
84+
85+
return;
86+
}
87+
7688
host.writeMultipleFiles(lazyModuleFiles);
7789
host.writeMultipleFiles(imports);
7890
addLazyLoadedModulesInTsConfig(host, lazyModuleFiles);

tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,13 @@ export default async function () {
8686
await ng('e2e');
8787
await ng('e2e', '--prod');
8888

89+
if (!(getGlobalVariable('argv')['ve'])) {
90+
// Only applicable to VE. Does not apply to Ivy.
91+
return;
92+
}
93+
8994
// Test string import.
90-
// Both Ivy and View Engine should support it.
95+
// View Engine should support it.
9196
await updateJsonFile('tsconfig.app.json', tsConfig => {
9297
tsConfig.files.push('src/app/lazy/lazy.module.ts');
9398
});

0 commit comments

Comments
 (0)