Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 1b341fb

Browse files
committed
a few more changes, incorporating thso's feedback
still more to do...
1 parent f609b3e commit 1b341fb

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

public/docs/_examples/dependency-injection/dart/lib/heroes/hero_service.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ class HeroService {
1616
List<Hero> getHeroes() {
1717
var auth = _isAuthorized ? 'authorized' : 'unauthorized';
1818
_logger.log('Getting heroes for $auth user.');
19-
return HEROES.where((hero) => _isAuthorized || !hero.isSecret).toList();
19+
return HEROES
20+
.where((hero) => _isAuthorized || !hero.isSecret)
21+
.toList();
2022
}
2123
// #enddocregion internals
2224
}

public/docs/_examples/dependency-injection/dart/lib/providers_component.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ class ProviderComponent6a {
149149
template: '{{log}}',
150150
providers:
151151
//#docregion providers-6b
152-
// Alias OldLogger w/ reference to NewLogger
152+
// Alias OldLogger with reference to NewLogger
153153
const [NewLogger, const Provider(OldLogger, useExisting: NewLogger)]
154154
//#enddocregion providers-6b
155155
)

public/docs/dart/latest/guide/dependency-injection.jade

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,13 @@ include ../_util-fns
126126
+includeShared('{ts}', 'logger-service-1')
127127
+makeExample(
128128
'dependency-injection/dart/lib/logger_service.dart',null, 'lib/logger_service')
129+
.l-sub-section
130+
:marked
131+
### Implementing a logger
132+
133+
Our examples use a simple logger.
134+
A real implementation would probably use the
135+
[logging package](https://pub.dartlang.org/packages/logging).
129136
:marked
130137
We're likely to need the same logger service everywhere in our application,
131138
so we put it in the `lib/` folder, and

0 commit comments

Comments
 (0)