Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Sample.css is used in the examples but never mentioned in the tutorial #1750

Closed
Adam-Meisen opened this issue Jun 26, 2016 · 2 comments
Closed

Comments

@Adam-Meisen
Copy link
Contributor

Adam-Meisen commented Jun 26, 2016

in part 6 of the Tour of Heroes tutorial, this example is used. The styles necessary to make the Delete buttons look like they do in that example aren't present anywhere in the tutorial. However, looking at both the live example and the app structure review shows an extra file not present in the previous chapter, sample.css. This file contains the rules to style the delete buttons.

button.delete-button{
float:right;
background-color: gray !important;
color:white;
}

@Adam-Meisen
Copy link
Contributor Author

My first thought was to move the contents of sample.css into styles.css, but these rules are specific to a single component, so they don't really belong there. They should go into the heroes.component.css file. However, this means they'll either have to be added to the style section in part 2, at which point the idea of deleting a hero hasn't been introduced yet, or part 6 should be edited to direct the reader to add these rules to heroes.component.css.

@Adam-Meisen
Copy link
Contributor Author

Fixed in #1751, closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant