fix(ngmodel): fixing many keys incorrectly marking inputs as dirty

Author: jbedard

src/ng/directive/input.js

@@ -949,6 +949,10 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
   }
 
   var listener = function(ev) {
+    if (timeout) {
+      $browser.defer.cancel(timeout);
+      timeout = null;
+    }
     if (composing) return;
     var value = element.val(),
         event = ev && ev.type;
@@ -975,11 +979,13 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
   } else {
     var timeout;
 
-    var deferListener = function(ev) {
+    var deferListener = function(ev, input, origValue) {
       if (!timeout) {
         timeout = $browser.defer(function() {
-          listener(ev);
           timeout = null;
+          if (!input || input.value !== origValue) {
+            listener(ev);
+          }
         });
       }
     };
@@ -991,7 +997,7 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
       //    command            modifiers                   arrows
       if (key === 91 || (15 < key && key < 19) || (37 <= key && key <= 40)) return;
 
-      deferListener(event);
+      deferListener(event, this, this.value);
     });
 
     // if user modifies input value using context menu in IE, we need "paste" and "cut" events to catch it

test/ng/directive/inputSpec.js

@@ -1569,6 +1569,41 @@ describe('input', function() {
         expect(inputElm).toBeDirty();
       }
     }));
+
+
+    //Cases created by using change/keydown/paste/cut instead of the input event
+    //TODO: these need to be verified better and preferably switched to integration tests
+    it('should dirty on keydown if the value changes', inject(function($browser) {
+      if (msie) {
+        compileInput('<input type="text" ng-model="name" />');
+        browserTrigger(inputElm, 'keydown');
+        $browser.defer.flush();
+        expect(inputElm).toBePristine();
+
+        browserTrigger(inputElm, 'keydown');
+        inputElm.val('f');
+        $browser.defer.flush();
+        expect(inputElm).toBeDirty();
+      }
+    }));
+
+    it('should cancel the delayed dirty if a change occurs', inject(function($browser) {
+      if (msie) {
+        compileInput('<input type="text" ng-model="name" />');
+        var ctrl = inputElm.controller('ngModel');
+
+        browserTrigger(inputElm, 'keydown', {target: inputElm[0]});
+        inputElm.val('f');
+        browserTrigger(inputElm, 'change');
+        expect(inputElm).toBeDirty();
+
+        ctrl.$setPristine();
+        expect(inputElm).toBePristine();
+
+        $browser.defer.flush();
+        expect(inputElm).toBePristine();
+      }
+    }));
   });