fix(copy): add support for String/Boolean/Number object types

Author: jbedard

src/Angular.js

@@ -554,7 +554,7 @@ function isBlankObject(value) {
  * @param {*} value Reference to check.
  * @returns {boolean} True if `value` is a `String`.
  */
-function isString(value) {return typeof value === 'string';}
+function isString(value) {return toString.call(value) === '[object String]';}
 
 
 /**
@@ -575,7 +575,7 @@ function isString(value) {return typeof value === 'string';}
  * @param {*} value Reference to check.
  * @returns {boolean} True if `value` is a `Number`.
  */
-function isNumber(value) {return typeof value === 'number';}
+function isNumber(value) {return toString.call(value) === '[object Number]';}
 
 
 /**
@@ -668,8 +668,8 @@ function isBlob(obj) {
 }
 
 
-function isBoolean(value) {
-  return typeof value === 'boolean';
+function isBoolean(obj) {
+  return toString.call(obj) === '[object Boolean]';
 }
 
 
@@ -888,6 +888,8 @@ function copy(source, destination) {
       needsRecurse = true;
     } else if (isTypedArray(source)) {
       destination = new source.constructor(source);
+    } else if (isBoolean(source) || isString(source) || isNumber(source)) {
+      destination = new source.constructor(source);
     } else if (isDate(source)) {
       destination = new Date(source.getTime());
     } else if (isRegExp(source)) {

test/AngularSpec.js

@@ -471,6 +471,30 @@ describe('angular', function() {
       expect(dest.c).toBe(3);
       expect(Object.keys(dest)).toEqual(['a', 'b', 'c']);
     });
+
+    it('should copy String() objects', function() {
+      var obj = new String('foo');
+      var dest = copy(obj);
+      expect(obj).not.toBe(dest);
+      expect(isString(dest)).toBe(true);
+      expect(obj + "").toBe(dest + "");
+    });
+
+    it('should copy Boolean() objects', function() {
+      var obj = new Boolean(true);
+      var dest = copy(obj);
+      expect(obj).not.toBe(dest);
+      expect(isBoolean(dest)).toBe(true);
+      expect(+obj).toBe(+dest);
+    });
+
+    it('should copy Number() objects', function() {
+      var obj = new Number(42);
+      var dest = copy(obj);
+      expect(obj).not.toBe(dest);
+      expect(isNumber(dest)).toBe(true);
+      expect(+obj).toBe(+dest);
+    });
   });
 
   describe("extend", function() {