Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit be0a5d7

Browse files
committed
fixup! fix($rootScope): provide correct value of one-time bindings in watchGroup
1 parent 8e7c4b4 commit be0a5d7

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

test/ng/rootScopeSpec.js

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,34 +1114,34 @@ describe('Scope', function() {
11141114
expect(scope.$$watchersCount).toBe(0);
11151115
});
11161116

1117-
it('should maintain correct new/old values with one time bindings', inject(function($rootScope, $exceptionHandler) {
1117+
it('should maintain correct new/old values with one time bindings', function() {
11181118
var newValues;
11191119
var oldValues;
1120-
$rootScope.$watchGroup(['a', '::b', 'b', '4'], function(n, o) {
1120+
scope.$watchGroup(['a', '::b', 'b', '4'], function(n, o) {
11211121
newValues = n.slice();
11221122
oldValues = o.slice();
11231123
});
11241124

1125-
$rootScope.$apply();
1125+
scope.$apply();
11261126
expect(newValues).toEqual(oldValues);
11271127
expect(oldValues).toEqual([undefined, undefined, undefined, 4]);
11281128

1129-
$rootScope.$apply('a = 1');
1129+
scope.$apply('a = 1');
11301130
expect(newValues).toEqual([1, undefined, undefined, 4]);
11311131
expect(oldValues).toEqual([undefined, undefined, undefined, 4]);
11321132

1133-
$rootScope.$apply('b = 2');
1133+
scope.$apply('b = 2');
11341134
expect(newValues).toEqual([1, 2, 2, 4]);
11351135
expect(oldValues).toEqual([1, undefined, undefined, 4]);
11361136

1137-
$rootScope.$apply('b = 3');
1137+
scope.$apply('b = 3');
11381138
expect(newValues).toEqual([1, 2, 3, 4]);
11391139
expect(oldValues).toEqual([1, 2, 2, 4]);
11401140

1141-
$rootScope.$apply('b = 4');
1141+
scope.$apply('b = 4');
11421142
expect(newValues).toEqual([1, 2, 4, 4]);
11431143
expect(oldValues).toEqual([1, 2, 3, 4]);
1144-
}));
1144+
});
11451145
});
11461146

11471147
describe('$watchGroup with logging $exceptionHandler', function() {
@@ -1150,36 +1150,36 @@ describe('Scope', function() {
11501150
$exceptionHandlerProvider.mode('log');
11511151
});
11521152

1153-
inject(function($rootScope, $exceptionHandler) {
1153+
inject(function($exceptionHandler) {
11541154
var newValues;
11551155
var oldValues;
1156-
$rootScope.$watchGroup(['a', '::b', 'b', '4'], function(n, o) {
1156+
scope.$watchGroup(['a', '::b', 'b', '4'], function(n, o) {
11571157
newValues = n.slice();
11581158
oldValues = o.slice();
11591159
throw 'test';
11601160
});
11611161

1162-
$rootScope.$apply();
1162+
scope.$apply();
11631163
expect(newValues).toEqual(oldValues);
11641164
expect(oldValues).toEqual([undefined, undefined, undefined, 4]);
11651165
expect($exceptionHandler.errors.length).toBe(1);
11661166

1167-
$rootScope.$apply('a = 1');
1167+
scope.$apply('a = 1');
11681168
expect(newValues).toEqual([1, undefined, undefined, 4]);
11691169
expect(oldValues).toEqual([undefined, undefined, undefined, 4]);
11701170
expect($exceptionHandler.errors.length).toBe(2);
11711171

1172-
$rootScope.$apply('b = 2');
1172+
scope.$apply('b = 2');
11731173
expect(newValues).toEqual([1, 2, 2, 4]);
11741174
expect(oldValues).toEqual([1, undefined, undefined, 4]);
11751175
expect($exceptionHandler.errors.length).toBe(3);
11761176

1177-
$rootScope.$apply('b = 3');
1177+
scope.$apply('b = 3');
11781178
expect(newValues).toEqual([1, 2, 3, 4]);
11791179
expect(oldValues).toEqual([1, 2, 2, 4]);
11801180
expect($exceptionHandler.errors.length).toBe(4);
11811181

1182-
$rootScope.$apply('b = 4');
1182+
scope.$apply('b = 4');
11831183
expect(newValues).toEqual([1, 2, 4, 4]);
11841184
expect(oldValues).toEqual([1, 2, 3, 4]);
11851185
expect($exceptionHandler.errors.length).toBe(5);

0 commit comments

Comments
 (0)