fix(copy): add support for String/Boolean/Number object types

Author: jbedard

src/Angular.js

@@ -668,8 +668,8 @@ function isBlob(obj) {
 }
 
 
-function isBoolean(value) {
-  return typeof value === 'boolean';
+function isBoolean(obj) {
+  return typeof obj === 'boolean';
 }
 
 
@@ -886,16 +886,7 @@ function copy(source, destination) {
     if (isArray(source)) {
       destination = [];
       needsRecurse = true;
-    } else if (isTypedArray(source)) {
-      destination = new source.constructor(source);
-    } else if (isDate(source)) {
-      destination = new Date(source.getTime());
-    } else if (isRegExp(source)) {
-      destination = new RegExp(source.source, source.toString().match(/[^\/]*$/)[0]);
-      destination.lastIndex = source.lastIndex;
-    } else if (isFunction(source.cloneNode)) {
-        destination = source.cloneNode(true);
-    } else {
+    } else if (!(destination = copyType(source))) {
       destination = Object.create(getPrototypeOf(source));
       needsRecurse = true;
     }
@@ -907,6 +898,36 @@ function copy(source, destination) {
       ? copyRecurse(source, destination)
       : destination;
   }
+
+  function copyType(source) {
+    switch (toString.call(source)) {
+      case '[object Int8Array]':
+      case '[object Int16Array]':
+      case '[object Int32Array]':
+      case '[object Float32Array]':
+      case '[object Float64Array]':
+      case '[object Uint8Array]':
+      case '[object Uint8ClampedArray]':
+      case '[object Uint16Array]':
+      case '[object Uint32Array]':
+      case '[object Boolean]':
+      case '[object Number]':
+      case '[object String]':
+        return new source.constructor(source);
+
+      case '[object Date]':
+        return new Date(source.getTime());
+
+      case '[object RegExp]':
+        var re = new RegExp(source.source, source.toString().match(/[^\/]*$/)[0]);
+        re.lastIndex = source.lastIndex;
+        return re;
+    }
+
+    if (isFunction(source.cloneNode)) {
+      return source.cloneNode(true);
+    }
+  }
 }
 
 /**

test/AngularSpec.js

@@ -471,6 +471,33 @@ describe('angular', function() {
       expect(dest.c).toBe(3);
       expect(Object.keys(dest)).toEqual(['a', 'b', 'c']);
     });
+
+    it('should copy String() objects', function() {
+      /*jshint -W053 */
+      var obj = new String('foo');
+      /*jshint +W053 */
+      var dest = copy(obj);
+      expect(obj).not.toBe(dest);
+      expect(obj + "").toBe(dest + "");
+    });
+
+    it('should copy Boolean() objects', function() {
+      /*jshint -W053 */
+      var obj = new Boolean(true);
+      /*jshint +W053 */
+      var dest = copy(obj);
+      expect(obj).not.toBe(dest);
+      expect(+obj).toBe(+dest);
+    });
+
+    it('should copy Number() objects', function() {
+      /*jshint -W053 */
+      var obj = new Number(42);
+      /*jshint +W053 */
+      var dest = copy(obj);
+      expect(obj).not.toBe(dest);
+      expect(+obj).toBe(+dest);
+    });
   });
 
   describe("extend", function() {