This repository was archived by the owner on Apr 12, 2024. It is now read-only.
In filters, use isArray instead of instanceof#1966
Closed
Ivshti wants to merge 2 commits intoangular:masterfrom
Ivshti:master
Closed
In filters, use isArray instead of instanceof#1966Ivshti wants to merge 2 commits intoangular:masterfrom Ivshti:master
Ivshti wants to merge 2 commits intoangular:masterfrom
Ivshti:master
Conversation
Contributor
|
PR Checklist (Minor Bugfix)
|
Contributor
|
Is there an easy way to create a browser based unit test for this? I can't think of any, so I'm ok with skipping unit tests for this one. please squash into a single commit, update commit message and sign CLA if you haven't yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the built-in isArray instead of "instanceof Array".
In the node-webkit framework, arrays may be created in the Node.js context, and for those arrays "instanceof Array" will return false, because the Array object of the browser context is a different reference. Using "Array.isArray" or the AngularJS function isArray fixes the problem.