Spec failing really badly with jQuery 2.0.3

[caitp]

As part of my fix for #5099, I was running tests with jQuery 2.0.3 --- Of course my test passes, but there are some unrelated failures. Two of them are in ngMocks, which may not be a big issue, but one $compile spec is a bit iffy, and it fails with or without my change:

Chrome 31.0.1650 (Mac OS X 10.9.1) $compile compile phase compiler control scope should allow creation of new scopes for replace directives with templates in a repeater FAILED
    Expected undefined to be { $id : '003', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '002', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : { $id : '004', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : { $id : '006', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : null, $$watchers : null, $$prevSibling : <circular reference: Object>, i : 3, $index : 2, $first : false, $last : true, $middle : false, $even : true, $odd : false }, $$watchers : null, $$prevSibling : <circular reference: Object>, i : 2, $index : 1, $first : false, $last : false, $middle : true, $even : false, $odd : true }, $$watchers : null, $$prevSibling : null, i : 1, $index : 0, $first : true, $last : false, $middle : false, $even : true, $odd : false }, $$childTail : null, $$childHead : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : Function, get : Function, exp : Function, eq : false } ], $$prevSibling : null }.
    Error: Expected undefined to be { $id : '003', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '002', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : { $id : '004', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : { $id : '006', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : null, $$watchers : null, $$prevSibling : <circular reference: Object>, i : 3, $index : 2, $first : false, $last : true, $middle : false, $even : true, $odd : false }, $$watchers : null, $$prevSibling : <circular reference: Object>, i : 2, $index : 1, $first : false, $last : false, $middle : true, $even : false, $odd : true }, $$watchers : null, $$prevSibling : null, i : 1, $index : 0, $first : true, $last : false, $middle : false, $even : true, $odd : false }, $$childTail : null, $$childHead : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : Function, get : Function, exp : Function, eq : false } ], $$prevSibling : null }.
        at /Users/caitp/git/angular.js/test/ng/compileSpec.js:1504:52
        at nodeLinkFn (/Users/caitp/git/angular.js/src/ng/compile.js:1529:13)
        at /Users/caitp/git/angular.js/src/ng/compile.js:1721:13
        at /Users/caitp/git/angular.js/src/ng/http.js:738:11
        at wrappedCallback (/Users/caitp/git/angular.js/src/ng/q.js:253:81)
        at wrappedCallback (/Users/caitp/git/angular.js/src/ng/q.js:253:81)
        at /Users/caitp/git/angular.js/src/ng/q.js:339:26
        at Scope.$eval (/Users/caitp/git/angular.js/src/ng/rootScope.js:745:28)
    Expected undefined to be { $id : '005', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '004', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : { $id : '006', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : null, $$watchers : null, $$prevSibling : <circular reference: Object>, i : 3, $index : 2, $first : false, $last : true, $middle : false, $even : true, $odd : false }, $$watchers : null, $$prevSibling : { $id : '002', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : <circular reference: Object>, $$watchers : null, $$prevSibling : null, i : 1, $index : 0, $first : true, $last : false, $middle : false, $even : true, $odd : false }, i : 2, $index : 1, $first : false, $last : false, $middle : true, $even : false, $odd : true }, $$childTail : null, $$childHead : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : Function, get : Function, exp : Function, eq : false } ], $$prevSibling : null }.
    Error: Expected undefined to be { $id : '005', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '004', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : { $id : '006', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : null, $$watchers : null, $$prevSibling : <circular reference: Object>, i : 3, $index : 2, $first : false, $last : true, $middle : false, $even : true, $odd : false }, $$watchers : null, $$prevSibling : { $id : '002', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : <circular reference: Object>, $$watchers : null, $$prevSibling : null, i : 1, $index : 0, $first : true, $last : false, $middle : false, $even : true, $odd : false }, i : 2, $index : 1, $first : false, $last : false, $middle : true, $even : false, $odd : true }, $$childTail : null, $$childHead : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : Function, get : Function, exp : Function, eq : false } ], $$prevSibling : null }.
        at /Users/caitp/git/angular.js/test/ng/compileSpec.js:1504:52
        at nodeLinkFn (/Users/caitp/git/angular.js/src/ng/compile.js:1529:13)
        at /Users/caitp/git/angular.js/src/ng/compile.js:1721:13
        at /Users/caitp/git/angular.js/src/ng/http.js:738:11
        at wrappedCallback (/Users/caitp/git/angular.js/src/ng/q.js:253:81)
        at wrappedCallback (/Users/caitp/git/angular.js/src/ng/q.js:253:81)
        at /Users/caitp/git/angular.js/src/ng/q.js:339:26
        at Scope.$eval (/Users/caitp/git/angular.js/src/ng/rootScope.js:745:28)
    Expected undefined to be { $id : '007', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '006', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : null, $$watchers : null, $$prevSibling : { $id : '004', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : <circular reference: Object>, $$watchers : null, $$prevSibling : { $id : '002', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : <circular reference: Object>, $$watchers : null, $$prevSibling : null, i : 1, $index : 0, $first : true, $last : false, $middle : false, $even : true, $odd : false }, i : 2, $index : 1, $first : false, $last : false, $middle : true, $even : false, $odd : true }, i : 3, $index : 2, $first : false, $last : true, $middle : false, $even : true, $odd : false }, $$childTail : null, $$childHead : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : Function, get : Function, exp : Function, eq : false } ], $$prevSibling : null }.
    Error: Expected undefined to be { $id : '007', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '006', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : null, $$watchers : null, $$prevSibling : { $id : '004', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : <circular reference: Object>, $$watchers : null, $$prevSibling : { $id : '002', this : <circular reference: Object>, $$listeners : {  }, $$listenerCount : {  }, $parent : { $id : '001', $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$prevSibling : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : 5, get : Function, exp : Function, eq : false } ], $parent : null, $$phase : '$digest', $root : <circular reference: Object>, this : <circular reference: Object>, $$destroyed : false, $$asyncQueue : [ { scope : <circular reference: Object>, expression : Function } ], $$postDigestQueue : [  ], $$listeners : {  }, $$listenerCount : {  }, $$isolateBindings : {  } }, $$childTail : <circular reference: Object>, $$childHead : <circular reference: Object>, $$nextSibling : <circular reference: Object>, $$watchers : null, $$prevSibling : null, i : 1, $index : 0, $first : true, $last : false, $middle : false, $even : true, $odd : false }, i : 2, $index : 1, $first : false, $last : false, $middle : true, $even : false, $odd : true }, i : 3, $index : 2, $first : false, $last : true, $middle : false, $even : true, $odd : false }, $$childTail : null, $$childHead : null, $$nextSibling : null, $$watchers : [ { fn : Function, last : Function, get : Function, exp : Function, eq : false } ], $$prevSibling : null }.
        at /Users/caitp/git/angular.js/test/ng/compileSpec.js:1504:52
        at nodeLinkFn (/Users/caitp/git/angular.js/src/ng/compile.js:1529:13)
        at /Users/caitp/git/angular.js/src/ng/compile.js:1721:13
        at /Users/caitp/git/angular.js/src/ng/http.js:738:11
        at wrappedCallback (/Users/caitp/git/angular.js/src/ng/q.js:253:81)
        at wrappedCallback (/Users/caitp/git/angular.js/src/ng/q.js:253:81)
        at /Users/caitp/git/angular.js/src/ng/q.js:339:26
        at Scope.$eval (/Users/caitp/git/angular.js/src/ng/rootScope.js:745:28)
    Expected '001' to be '003'.
    Error: Expected '001' to be '003'.
        at null.<anonymous> (/Users/caitp/git/angular.js/test/ng/compileSpec.js:1589:49)
        at Object.invoke (/Users/caitp/git/angular.js/src/auto/injector.js:779:17)
        at workFn (/Users/caitp/git/angular.js/src/ngMock/angular-mocks.js:2113:20)
    Expected '001' to be '003'.
    Error: Expected '001' to be '003'.
        at null.<anonymous> (/Users/caitp/git/angular.js/test/ng/compileSpec.js:1590:49)
        at Object.invoke (/Users/caitp/git/angular.js/src/auto/injector.js:779:17)
        at workFn (/Users/caitp/git/angular.js/src/ngMock/angular-mocks.js:2113:20)

It might be good to investigate this to make sure stuff isn't failing in really awkward ways with modern versions of jQuery.

[IgorMinar]

we don't support jQuery 2.x yet. it requires a breaking change so 1.3 will support it.

we could possibly think of a smart solution to support both jQuery 1.x and 2.x in 1.2.x but given all the stuff going on, our original plan was to switch to jQuery 2.x in early 1.3 beta builds

[IgorMinar]

PR in progress: #4271 (we punted on the PR because of the stuff I mentioned above)

[caitp]

Ah I see, thanks