Skip to content

Can we get priority returned in AFUnwrappedDataSnapshot? #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lyonzy opened this issue Sep 25, 2017 · 4 comments
Closed

Can we get priority returned in AFUnwrappedDataSnapshot? #1164

lyonzy opened this issue Sep 25, 2017 · 4 comments

Comments

@lyonzy
Copy link

lyonzy commented Sep 25, 2017

It would be nice to have Priority returned in the unwrapped DataSnapshot. It looks like this is a minor change to unwrapMapFn in utils.ts.

This would help those of us ordering by (and manipulating) priority in our apps.

Either a property or function is fine (looking at $key and $exists, perhaps a function called $priority?)

Cheers,
Matt

@lyonzy
Copy link
Author

lyonzy commented Sep 25, 2017

Just created pull request #1165 for this.

@Toxicable
Copy link

Might want to hold off on that for now, there's a proposal to swap out the DB API for a new one #1158

@davideast
Copy link
Collaborator

Hey @lyonzy! As @Toxicable said there are changes coming to the library that conflict with this request. I commented more in your PR, but you will get similar functionality in the upcoming release so hold tight 👍

@lyonzy
Copy link
Author

lyonzy commented Sep 27, 2017

No worries. I only use this for debugging anyway so in the meantime I've just patched it into my own node_modules dir. Looking forward to the new API 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants