Skip to content

Add support for getting document's id in CollectionGroupQuery #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonxabris opened this issue Aug 30, 2020 · 2 comments
Closed

Add support for getting document's id in CollectionGroupQuery #2579

simonxabris opened this issue Aug 30, 2020 · 2 comments

Comments

@simonxabris
Copy link
Contributor

Version info

Angular: 9.1.6

Firebase: 7.15.0

AngularFire: 6.02

Hi!

I'm using angularfire on a project and I've tried to use collectionGroup.valueChanges({ idField: 'docId' }) to retrieve a collection group with the document ids mapped to the docId property as I saw in the docs. When I tried this, TS complained that the valueChanges function does not expect any arguments, so I took a quick look at the source and found out that the implementation is missing.

I'll be providing a PR with the implementation of this shortly.

@jamesdaniels
Copy link
Member

Addressed in 6.1 :)

@simonxabris
Copy link
Contributor Author

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants