From c34aeefaf09c259609c83962b3c9cdb32a06eb4e Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 09:18:45 -0500 Subject: [PATCH 01/15] Do pruning on build, only cache node_modules on 14 --- .github/workflows/test.yml | 63 +++++++++++++++++++++----------------- 1 file changed, 35 insertions(+), 28 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b029135f2..2156ada67 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,19 +21,22 @@ jobs: uses: actions/setup-node@v2-beta with: node-version: '14' - - name: Use yarn cache + - name: Yarn offline cache uses: actions/cache@v2 with: - path: | - ./node_modules - ~/.npm-packages-offline-cache - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.os }}-yarn- - ${{ runner.os }}- + path: ~/.npm-packages-offline-cache + key: ${{ runner.os }}-yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: ${{ runner.os }}-yarn-offline- + - name: node_modules cache + uses: actions/cache@v2 + with: + path: ./node_modules + key: ${{ runner.os }}-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: ${{ runner.os }}-node_modules- - name: Install deps run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache + yarn config set yarn-offline-mirror-pruning true yarn install --frozen-lockfile --prefer-offline - name: Build id: yarn-pack-dir @@ -44,6 +47,7 @@ jobs: name: angularfire-${{ github.run_id }} path: dist retention-days: 1 + test: runs-on: ubuntu-latest needs: build @@ -59,17 +63,20 @@ jobs: with: node-version: ${{ matrix.node }} check-latest: true - - name: Use yarn cache + - name: Yarn offline cache + uses: actions/cache@v2 + with: + path: ~/.npm-packages-offline-cache + key: ${{ runner.os }}-yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: ${{ runner.os }}-yarn-offline- + - name: node_modules cache uses: actions/cache@v2 + if: ${{ matrix.node == '14' }} with: - path: | - ./node_modules - ~/.npm-packages-offline-cache - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.os }}-yarn- - ${{ runner.os }}- - - name: Use Firebase emulator cache + path: ./node_modules + key: ${{ runner.os }}-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: ${{ runner.os }}-node_modules- + - name: Firebase emulator cache uses: actions/cache@v2 with: path: ~/.cache/firebase/emulators @@ -77,7 +84,6 @@ jobs: - name: Install deps run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache - yarn config set yarn-offline-mirror-pruning true yarn install --frozen-lockfile --prefer-offline - name: 'Download Artifacts' uses: actions/download-artifact@v2 @@ -97,17 +103,19 @@ jobs: with: node-version: '14' check-latest: true - - name: Use yarn cache + - name: Yarn offline cache uses: actions/cache@v2 with: - path: | - ./node_modules - ~/.npm-packages-offline-cache - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.os }}-yarn- - ${{ runner.os }}- - - name: Use Firebase emulator cache + path: ~/.npm-packages-offline-cache + key: ${{ runner.os }}-yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: ${{ runner.os }}-yarn-offline- + - name: node_modules cache + uses: actions/cache@v2 + with: + path: ./node_modules + key: ${{ runner.os }}-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: ${{ runner.os }}-node_modules- + - name: Firebase emulator cache uses: actions/cache@v2 with: path: ~/.cache/firebase/emulators @@ -115,7 +123,6 @@ jobs: - name: Install deps run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache - yarn config set yarn-offline-mirror-pruning true yarn install --frozen-lockfile --prefer-offline - name: 'Download Artifacts' uses: actions/download-artifact@v2 From 0f50124deee8cf4ff403063c7025287edd45f515 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 09:43:51 -0500 Subject: [PATCH 02/15] Firebase matrix --- .github/workflows/test.yml | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2156ada67..a26d51855 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -54,7 +54,8 @@ jobs: strategy: matrix: node: ["10", "12", "14"] - name: Test Node.js ${{ matrix.node }} (Ubuntu) + firebase: ["7", "8"] + name: Test Firebase v${{ matrix.firebase }} on Node.js ${{ matrix.node }} steps: - name: Checkout uses: actions/checkout@v2 @@ -85,16 +86,22 @@ jobs: run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline + - name: Bump Firebase + run: yarn add firebase@^${{ matrix.firebase }}.0 - name: 'Download Artifacts' uses: actions/download-artifact@v2 - name: Run tests run: | mv angularfire-${{ github.run_id }} dist yarn test:node + headless: runs-on: ubuntu-latest needs: build - name: Test Headless Chrome (Ubuntu) + name: Test Firebase v${{ matrix.firebase }} on Headless Chrome + strategy: + matrix: + firebase: ["7", "8"] steps: - name: Checkout uses: actions/checkout@v2 @@ -124,12 +131,15 @@ jobs: run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline + - name: Bump Firebase + run: yarn add firebase@^${{ matrix.firebase }}.0 - name: 'Download Artifacts' uses: actions/download-artifact@v2 - name: Run tests run: | mv angularfire-${{ github.run_id }} dist yarn test:chrome-headless + publish: runs-on: ubuntu-latest name: Publish (NPM) From f4e308b8cb3bfafcf083eb943bd05a4f2c2491f2 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 09:58:56 -0500 Subject: [PATCH 03/15] Fixes for v7 headless --- src/database/database.ts | 1 + src/storage/observable/fromTask.ts | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/src/database/database.ts b/src/database/database.ts index 54e87ff8c..4d2d7cc21 100644 --- a/src/database/database.ts +++ b/src/database/database.ts @@ -58,6 +58,7 @@ export class AngularFireDatabase { this.database = ɵfetchInstance(`${app.name}.database.${databaseURL}`, 'AngularFireDatabase', app, () => { const database = zone.runOutsideAngular(() => app.database(databaseURL || undefined)); if (useEmulator) { + // @ts-ignore keep from failing on v7 headless database.useEmulator(...useEmulator); } return database; diff --git a/src/storage/observable/fromTask.ts b/src/storage/observable/fromTask.ts index a4442dd1e..ddbb9f388 100644 --- a/src/storage/observable/fromTask.ts +++ b/src/storage/observable/fromTask.ts @@ -2,6 +2,10 @@ import { Observable } from 'rxjs'; import { shareReplay } from 'rxjs/operators'; import { UploadTask, UploadTaskSnapshot } from '../interfaces'; +// need to import, else the types become import('firebase/app').default.storage.UploadTask +// and it no longer works w/Firebase v7 +import firebase from 'firebase/app'; + export function fromTask(task: UploadTask) { return new Observable(subscriber => { const progress = (snap: UploadTaskSnapshot) => subscriber.next(snap); From e78f60247d181f4e2c6ff975b3ce3e62560a2764 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 10:07:06 -0500 Subject: [PATCH 04/15] Fix spec import of database --- src/database/list/changes.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/database/list/changes.spec.ts b/src/database/list/changes.spec.ts index ae87b837f..b5e5209c5 100644 --- a/src/database/list/changes.spec.ts +++ b/src/database/list/changes.spec.ts @@ -1,6 +1,6 @@ import firebase from 'firebase/app'; import { AngularFireModule, FirebaseApp } from '@angular/fire'; -import { AngularFireDatabase, AngularFireDatabaseModule, listChanges, URL } from '../public_api'; +import { AngularFireDatabase, AngularFireDatabaseModule, listChanges, URL } from '@angular/fire/database'; import { TestBed } from '@angular/core/testing'; import { COMMON_CONFIG } from '../../test-config'; import { skip, take } from 'rxjs/operators'; From b127f2b5ae9000e9b5d28b95a3dff49b561a18b1 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 10:18:13 -0500 Subject: [PATCH 05/15] With fixed database import it shouldnt recompile --- src/database/database.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/database/database.ts b/src/database/database.ts index 4d2d7cc21..54e87ff8c 100644 --- a/src/database/database.ts +++ b/src/database/database.ts @@ -58,7 +58,6 @@ export class AngularFireDatabase { this.database = ɵfetchInstance(`${app.name}.database.${databaseURL}`, 'AngularFireDatabase', app, () => { const database = zone.runOutsideAngular(() => app.database(databaseURL || undefined)); if (useEmulator) { - // @ts-ignore keep from failing on v7 headless database.useEmulator(...useEmulator); } return database; From b37928f5b9beab90aa4c1639d68f51b4ade7dec6 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 10:24:09 -0500 Subject: [PATCH 06/15] Let Node 10 & 12 cache too, rename keys --- .github/workflows/test.yml | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a26d51855..16f73366a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -25,14 +25,14 @@ jobs: uses: actions/cache@v2 with: path: ~/.npm-packages-offline-cache - key: ${{ runner.os }}-yarn-offline-${{ hashFiles('**/yarn.lock') }} - restore-keys: ${{ runner.os }}-yarn-offline- + key: yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: yarn-offline - name: node_modules cache uses: actions/cache@v2 with: path: ./node_modules - key: ${{ runner.os }}-node_modules-${{ hashFiles('yarn.lock') }} - restore-keys: ${{ runner.os }}-node_modules- + key: ${{ runner.os }}-14-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: ${{ runner.os }}-14-node_modules- - name: Install deps run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache @@ -68,15 +68,14 @@ jobs: uses: actions/cache@v2 with: path: ~/.npm-packages-offline-cache - key: ${{ runner.os }}-yarn-offline-${{ hashFiles('**/yarn.lock') }} - restore-keys: ${{ runner.os }}-yarn-offline- + key: yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: yarn-offline - name: node_modules cache uses: actions/cache@v2 - if: ${{ matrix.node == '14' }} with: path: ./node_modules - key: ${{ runner.os }}-node_modules-${{ hashFiles('yarn.lock') }} - restore-keys: ${{ runner.os }}-node_modules- + key: ${{ runner.os }}-${{ matrix.node }}-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: ${{ runner.os }}-${{ matrix.node }}-node_modules- - name: Firebase emulator cache uses: actions/cache@v2 with: @@ -114,14 +113,14 @@ jobs: uses: actions/cache@v2 with: path: ~/.npm-packages-offline-cache - key: ${{ runner.os }}-yarn-offline-${{ hashFiles('**/yarn.lock') }} - restore-keys: ${{ runner.os }}-yarn-offline- + key: yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: yarn-offline - name: node_modules cache uses: actions/cache@v2 with: path: ./node_modules - key: ${{ runner.os }}-node_modules-${{ hashFiles('yarn.lock') }} - restore-keys: ${{ runner.os }}-node_modules- + key: ${{ runner.os }}-14-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: ${{ runner.os }}-14-node_modules- - name: Firebase emulator cache uses: actions/cache@v2 with: From 6e55c74da29d7525d44df34795022535b1245c1a Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 10:44:12 -0500 Subject: [PATCH 07/15] --prefer-offline for firebase install --- .github/workflows/test.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 16f73366a..31846762b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -85,8 +85,7 @@ jobs: run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - - name: Bump Firebase - run: yarn add firebase@^${{ matrix.firebase }}.0 + yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline - name: 'Download Artifacts' uses: actions/download-artifact@v2 - name: Run tests @@ -130,8 +129,7 @@ jobs: run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - - name: Bump Firebase - run: yarn add firebase@^${{ matrix.firebase }}.0 + yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline - name: 'Download Artifacts' uses: actions/download-artifact@v2 - name: Run tests From 46c4ece500ef9dc54eb8d19ba59c6da8b4eb7458 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 10:59:17 -0500 Subject: [PATCH 08/15] Skip on cache hits --- .github/workflows/test.yml | 63 ++++++++++++++++++++++---------------- 1 file changed, 37 insertions(+), 26 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 31846762b..5ac883473 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,19 +21,22 @@ jobs: uses: actions/setup-node@v2-beta with: node-version: '14' - - name: Yarn offline cache - uses: actions/cache@v2 - with: - path: ~/.npm-packages-offline-cache - key: yarn-offline-${{ hashFiles('**/yarn.lock') }} - restore-keys: yarn-offline - name: node_modules cache uses: actions/cache@v2 + id: node_modules_cache with: path: ./node_modules key: ${{ runner.os }}-14-node_modules-${{ hashFiles('yarn.lock') }} restore-keys: ${{ runner.os }}-14-node_modules- + - name: Yarn offline cache + if: steps.node_modules_cache.outputs.cache-hit != 'true' + uses: actions/cache@v2 + with: + path: ~/.npm-packages-offline-cache + key: yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: yarn-offline - name: Install deps + if: steps.node_modules_cache.outputs.cache-hit != 'true' run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn config set yarn-offline-mirror-pruning true @@ -64,28 +67,32 @@ jobs: with: node-version: ${{ matrix.node }} check-latest: true - - name: Yarn offline cache - uses: actions/cache@v2 - with: - path: ~/.npm-packages-offline-cache - key: yarn-offline-${{ hashFiles('**/yarn.lock') }} - restore-keys: yarn-offline - name: node_modules cache + id: node_modules_cache uses: actions/cache@v2 with: path: ./node_modules key: ${{ runner.os }}-${{ matrix.node }}-node_modules-${{ hashFiles('yarn.lock') }} restore-keys: ${{ runner.os }}-${{ matrix.node }}-node_modules- - - name: Firebase emulator cache + - name: Yarn offline cache + if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 with: - path: ~/.cache/firebase/emulators - key: firebase_emulators + path: ~/.npm-packages-offline-cache + key: yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: yarn-offline - name: Install deps + if: steps.node_modules_cache.outputs.cache-hit != 'true' run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline + - name: Bump Firebase + run: yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline + - name: Firebase emulator cache + uses: actions/cache@v2 + with: + path: ~/.cache/firebase/emulators + key: firebase_emulators - name: 'Download Artifacts' uses: actions/download-artifact@v2 - name: Run tests @@ -108,28 +115,32 @@ jobs: with: node-version: '14' check-latest: true - - name: Yarn offline cache - uses: actions/cache@v2 - with: - path: ~/.npm-packages-offline-cache - key: yarn-offline-${{ hashFiles('**/yarn.lock') }} - restore-keys: yarn-offline - name: node_modules cache + id: node_modules_cache uses: actions/cache@v2 with: path: ./node_modules key: ${{ runner.os }}-14-node_modules-${{ hashFiles('yarn.lock') }} restore-keys: ${{ runner.os }}-14-node_modules- - - name: Firebase emulator cache + - name: Yarn offline cache + if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 with: - path: ~/.cache/firebase/emulators - key: firebase_emulators + path: ~/.npm-packages-offline-cache + key: yarn-offline-${{ hashFiles('**/yarn.lock') }} + restore-keys: yarn-offline - name: Install deps + if: steps.node_modules_cache.outputs.cache-hit != 'true' run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline + - name: Bump Firebase + run: yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline + - name: Firebase emulator cache + uses: actions/cache@v2 + with: + path: ~/.cache/firebase/emulators + key: firebase_emulators - name: 'Download Artifacts' uses: actions/download-artifact@v2 - name: Run tests From b4e48540259beb4b86446eb332ae63cb636fb1d4 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 11:15:15 -0500 Subject: [PATCH 09/15] Include v7 in the cache with an alias, offline --- .github/workflows/test.yml | 4 +- package.json | 3 +- yarn.lock | 228 ++++++++++++++++++++++++++++++------- 3 files changed, 193 insertions(+), 42 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5ac883473..f67d7e2cb 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -87,7 +87,7 @@ jobs: yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - name: Bump Firebase - run: yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline + run: yarn add firebase@^${{ matrix.firebase }}.0 --offline - name: Firebase emulator cache uses: actions/cache@v2 with: @@ -135,7 +135,7 @@ jobs: yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - name: Bump Firebase - run: yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline + run: yarn add firebase@^${{ matrix.firebase }}.0 --offline - name: Firebase emulator cache uses: actions/cache@v2 with: diff --git a/package.json b/package.json index bdffd4b66..cba3108bc 100644 --- a/package.json +++ b/package.json @@ -49,10 +49,11 @@ "@angular/platform-browser": "^9.0.0 || ^10.0.0 || ^11.0.0", "@angular/platform-browser-dynamic": "^9.0.0 || ^10.0.0 || ^11.0.0", "@angular/router": "^9.0.0 || ^10.0.0 || ^11.0.0", - "firebase": "^7.0.0 || ^8.0.0", + "firebase": "^7.0 || ^8.0", "firebase-admin": "^8.10.0", "firebase-functions": "^3.6.0", "firebase-tools": "^8.0.0", + "firebase7": "^7.0", "fs-extra": "^8.0.1", "fuzzy": "^0.1.3", "husky": "^4.2.5", diff --git a/yarn.lock b/yarn.lock index 1b0da872e..df3b697d5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1157,6 +1157,18 @@ resolved "https://registry.yarnpkg.com/@firebase/analytics-types/-/analytics-types-0.4.0.tgz#d6716f9fa36a6e340bc0ecfe68af325aa6f60508" integrity sha512-Jj2xW+8+8XPfWGkv9HPv/uR+Qrmq37NPYT352wf7MvE9LrstpLVmFg3LqG6MCRr5miLAom5sen2gZ+iOhVDeRA== +"@firebase/analytics@0.6.0": + version "0.6.0" + resolved "https://registry.yarnpkg.com/@firebase/analytics/-/analytics-0.6.0.tgz#49f508d3f9f419f08c503f1171ef5fa1c3ba52eb" + integrity sha512-6qYEOPUVYrMhqvJ46Z5Uf1S4uULd6d7vGpMP5Qz+u8kIWuOQGcPdJKQap+Hla6Rq164or9gC2HRXuYXKlgWfpw== + dependencies: + "@firebase/analytics-types" "0.4.0" + "@firebase/component" "0.1.19" + "@firebase/installations" "0.4.17" + "@firebase/logger" "0.2.6" + "@firebase/util" "0.3.2" + tslib "^1.11.1" + "@firebase/analytics@0.6.2": version "0.6.2" resolved "https://registry.yarnpkg.com/@firebase/analytics/-/analytics-0.6.2.tgz#7f45675a1b524fff4d9e9fe318fd6e2ed067a325" @@ -1174,6 +1186,19 @@ resolved "https://registry.yarnpkg.com/@firebase/app-types/-/app-types-0.6.1.tgz#dcbd23030a71c0c74fc95d4a3f75ba81653850e9" integrity sha512-L/ZnJRAq7F++utfuoTKX4CLBG5YR7tFO3PLzG1/oXXKEezJ0kRL3CMRoueBEmTCzVb/6SIs2Qlaw++uDgi5Xyg== +"@firebase/app@0.6.11": + version "0.6.11" + resolved "https://registry.yarnpkg.com/@firebase/app/-/app-0.6.11.tgz#f73f9e4571ba62f4029d8f9c9880a97e5a94eb1d" + integrity sha512-FH++PaoyTzfTAVuJ0gITNYEIcjT5G+D0671La27MU8Vvr6MTko+5YUZ4xS9QItyotSeRF4rMJ1KR7G8LSyySiA== + dependencies: + "@firebase/app-types" "0.6.1" + "@firebase/component" "0.1.19" + "@firebase/logger" "0.2.6" + "@firebase/util" "0.3.2" + dom-storage "2.1.0" + tslib "^1.11.1" + xmlhttprequest "1.8.0" + "@firebase/app@0.6.13": version "0.6.13" resolved "https://registry.yarnpkg.com/@firebase/app/-/app-0.6.13.tgz#f2e9fa9e75815e54161dc34659a60f1fffd9a450" @@ -1197,10 +1222,17 @@ resolved "https://registry.yarnpkg.com/@firebase/auth-types/-/auth-types-0.10.1.tgz#7815e71c9c6f072034415524b29ca8f1d1770660" integrity sha512-/+gBHb1O9x/YlG7inXfxff/6X3BPZt4zgBv4kql6HEmdzNQCodIRlEYnI+/da+lN+dha7PjaFH7C7ewMmfV7rw== -"@firebase/auth@0.15.1": - version "0.15.1" - resolved "https://registry.yarnpkg.com/@firebase/auth/-/auth-0.15.1.tgz#2e0e7397d6f754d81916babd9bce21a51f4b25a3" - integrity sha512-qVJTmq/6l3/o6V93nAD+n1ExTywbKEFYbuuI1TZIUryy5KSXOFnxilmZI4yJeQSZ3ee06YiJsIRYRaYUeg6JQQ== +"@firebase/auth@0.15.0": + version "0.15.0" + resolved "https://registry.yarnpkg.com/@firebase/auth/-/auth-0.15.0.tgz#45d6def6d6d9444432c005710df442991828275f" + integrity sha512-IFuzhxS+HtOQl7+SZ/Mhaghy/zTU7CENsJFWbC16tv2wfLZbayKF5jYGdAU3VFLehgC8KjlcIWd10akc3XivfQ== + dependencies: + "@firebase/auth-types" "0.10.1" + +"@firebase/auth@0.15.2": + version "0.15.2" + resolved "https://registry.yarnpkg.com/@firebase/auth/-/auth-0.15.2.tgz#9ada3f37620d131a1c56994138a599b5c9f9ca2e" + integrity sha512-2n32PBi6x9jVhc0E/ewKLUCYYTzFEXL4PNkvrrlGKbzeTBEkkyzfgUX7OV9UF5wUOG+gurtUthuur1zspZ/9hg== dependencies: "@firebase/auth-types" "0.10.1" @@ -1227,27 +1259,14 @@ dependencies: "@firebase/app-types" "0.6.1" -"@firebase/database-types@0.6.0": - version "0.6.0" - resolved "https://registry.yarnpkg.com/@firebase/database-types/-/database-types-0.6.0.tgz#7795bc6b1db93f4cbda9a241c8dfe1bb86033dc6" - integrity sha512-ljpU7/uboCGqFSe9CNgwd3+Xu5N8YCunzfPpeueuj2vjnmmypUi4QWxgC3UKtGbuv1q+crjeudZGLxnUoO0h7w== +"@firebase/database-types@0.6.1": + version "0.6.1" + resolved "https://registry.yarnpkg.com/@firebase/database-types/-/database-types-0.6.1.tgz#cf1cfc03e617ed4c2561703781f85ba4c707ff65" + integrity sha512-JtL3FUbWG+bM59iYuphfx9WOu2Mzf0OZNaqWiQ7lJR8wBe7bS9rIm9jlBFtksB7xcya1lZSQPA/GAy2jIlMIkA== dependencies: "@firebase/app-types" "0.6.1" -"@firebase/database@0.7.1": - version "0.7.1" - resolved "https://registry.yarnpkg.com/@firebase/database/-/database-0.7.1.tgz#900d2e6ed734249e65e5f159293830e4f4285d6e" - integrity sha512-8j3KwksaYMSbIsEjOIarZD3vj4jGJjIlLGIAiO/4P4XyOtrlnxIiH7G0UdIZlcvKU4Gsgg0nthT2+EapROmHWA== - dependencies: - "@firebase/auth-interop-types" "0.1.5" - "@firebase/component" "0.1.21" - "@firebase/database-types" "0.6.0" - "@firebase/logger" "0.2.6" - "@firebase/util" "0.3.4" - faye-websocket "0.11.3" - tslib "^1.11.1" - -"@firebase/database@^0.6.0": +"@firebase/database@0.6.13", "@firebase/database@^0.6.0": version "0.6.13" resolved "https://registry.yarnpkg.com/@firebase/database/-/database-0.6.13.tgz#b96fe0c53757dd6404ee085fdcb45c0f9f525c17" integrity sha512-NommVkAPzU7CKd1gyehmi3lz0K78q0KOfiex7Nfy7MBMwknLm7oNqKovXSgQV1PCLvKXvvAplDSFhDhzIf9obA== @@ -1260,31 +1279,80 @@ faye-websocket "0.11.3" tslib "^1.11.1" +"@firebase/database@0.8.1": + version "0.8.1" + resolved "https://registry.yarnpkg.com/@firebase/database/-/database-0.8.1.tgz#a7bc1c01052d35817a242c21bfe09ab29ee485a3" + integrity sha512-/1HhR4ejpqUaM9Cn3KSeNdQvdlehWIhdfTVWFxS73ZlLYf7ayk9jITwH10H3ZOIm5yNzxF67p/U7Z/0IPhgWaQ== + dependencies: + "@firebase/auth-interop-types" "0.1.5" + "@firebase/component" "0.1.21" + "@firebase/database-types" "0.6.1" + "@firebase/logger" "0.2.6" + "@firebase/util" "0.3.4" + faye-websocket "0.11.3" + tslib "^1.11.1" + +"@firebase/firestore-types@1.14.0": + version "1.14.0" + resolved "https://registry.yarnpkg.com/@firebase/firestore-types/-/firestore-types-1.14.0.tgz#4516249d3c181849fd3c856831944dbd5c8c55fc" + integrity sha512-WF8IBwHzZDhwyOgQnmB0pheVrLNP78A8PGxk1nxb/Nrgh1amo4/zYvFMGgSsTeaQK37xMYS/g7eS948te/dJxw== + "@firebase/firestore-types@2.0.0": version "2.0.0" resolved "https://registry.yarnpkg.com/@firebase/firestore-types/-/firestore-types-2.0.0.tgz#1f6212553b240f1a8905bb8dcf1f87769138c5c0" integrity sha512-ZGb7p1SSQJP0Z+kc9GAUi+Fx5rJatFddBrS1ikkayW+QHfSIz0omU23OgSHcBGTxe8dJCeKiKA2Yf+tkDKO/LA== -"@firebase/firestore@2.0.1": - version "2.0.1" - resolved "https://registry.yarnpkg.com/@firebase/firestore/-/firestore-2.0.1.tgz#2d4734ecd5d165582eedea8487849c5535a55c0e" - integrity sha512-7WMv3b+2P/6SOE0RxPB+S6k75/vYTDhOpPBp6JH6nPQjS9mGtR9m0adKtXjOBBugcbK6sBgPMzxmQGwQl8lW4w== +"@firebase/firestore@1.18.0": + version "1.18.0" + resolved "https://registry.yarnpkg.com/@firebase/firestore/-/firestore-1.18.0.tgz#3430e8c60d3e6be1d174b3a258838b1944c93a4d" + integrity sha512-maMq4ltkrwjDRusR2nt0qS4wldHQMp+0IDSfXIjC+SNmjnWY/t/+Skn9U3Po+dB38xpz3i7nsKbs+8utpDnPSw== + dependencies: + "@firebase/component" "0.1.19" + "@firebase/firestore-types" "1.14.0" + "@firebase/logger" "0.2.6" + "@firebase/util" "0.3.2" + "@firebase/webchannel-wrapper" "0.4.0" + "@grpc/grpc-js" "^1.0.0" + "@grpc/proto-loader" "^0.5.0" + node-fetch "2.6.1" + tslib "^1.11.1" + +"@firebase/firestore@2.0.4": + version "2.0.4" + resolved "https://registry.yarnpkg.com/@firebase/firestore/-/firestore-2.0.4.tgz#c4be6f3540f607fd8e200cfba83c4997c29447fe" + integrity sha512-fzJKj/4h4jOwPSfHB42XBJIC0zsPsepU6FcBO+8nSx7G2IPfTw8cMgSNin2gPqX6tR1w1NQtHiSlXiRKsbMZdA== dependencies: "@firebase/component" "0.1.21" "@firebase/firestore-types" "2.0.0" "@firebase/logger" "0.2.6" "@firebase/util" "0.3.4" - "@firebase/webchannel-wrapper" "0.4.0" + "@firebase/webchannel-wrapper" "0.4.1" "@grpc/grpc-js" "^1.0.0" "@grpc/proto-loader" "^0.5.0" node-fetch "2.6.1" tslib "^1.11.1" +"@firebase/functions-types@0.3.17": + version "0.3.17" + resolved "https://registry.yarnpkg.com/@firebase/functions-types/-/functions-types-0.3.17.tgz#348bf5528b238eeeeeae1d52e8ca547b21d33a94" + integrity sha512-DGR4i3VI55KnYk4IxrIw7+VG7Q3gA65azHnZxo98Il8IvYLr2UTBlSh72dTLlDf25NW51HqvJgYJDKvSaAeyHQ== + "@firebase/functions-types@0.4.0": version "0.4.0" resolved "https://registry.yarnpkg.com/@firebase/functions-types/-/functions-types-0.4.0.tgz#0b789f4fe9a9c0b987606c4da10139345b40f6b9" integrity sha512-3KElyO3887HNxtxNF1ytGFrNmqD+hheqjwmT3sI09FaDCuaxGbOnsXAXH2eQ049XRXw9YQpHMgYws/aUNgXVyQ== +"@firebase/functions@0.5.1": + version "0.5.1" + resolved "https://registry.yarnpkg.com/@firebase/functions/-/functions-0.5.1.tgz#fa0568bdcdf7dfa7e5f4f66c1e06e376dc7e25b6" + integrity sha512-yyjPZXXvzFPjkGRSqFVS5Hc2Y7Y48GyyMH+M3i7hLGe69r/59w6wzgXKqTiSYmyE1pxfjxU4a1YqBDHNkQkrYQ== + dependencies: + "@firebase/component" "0.1.19" + "@firebase/functions-types" "0.3.17" + "@firebase/messaging-types" "0.5.0" + node-fetch "2.6.1" + tslib "^1.11.1" + "@firebase/functions@0.6.1": version "0.6.1" resolved "https://registry.yarnpkg.com/@firebase/functions/-/functions-0.6.1.tgz#32640b8f877637057dfaaeb122be8c8e99ad1af7" @@ -1301,6 +1369,17 @@ resolved "https://registry.yarnpkg.com/@firebase/installations-types/-/installations-types-0.3.4.tgz#589a941d713f4f64bf9f4feb7f463505bab1afa2" integrity sha512-RfePJFovmdIXb6rYwtngyxuEcWnOrzdZd9m7xAW0gRxDIjBT20n3BOhjpmgRWXo/DAxRmS7bRjWAyTHY9cqN7Q== +"@firebase/installations@0.4.17": + version "0.4.17" + resolved "https://registry.yarnpkg.com/@firebase/installations/-/installations-0.4.17.tgz#1367b721e2c6c4880646bbc4f257e8616986a004" + integrity sha512-AE/TyzIpwkC4UayRJD419xTqZkKzxwk0FLht3Dci8WI2OEKHSwoZG9xv4hOBZebe+fDzoV2EzfatQY8c/6Avig== + dependencies: + "@firebase/component" "0.1.19" + "@firebase/installations-types" "0.3.4" + "@firebase/util" "0.3.2" + idb "3.0.2" + tslib "^1.11.1" + "@firebase/installations@0.4.19": version "0.4.19" resolved "https://registry.yarnpkg.com/@firebase/installations/-/installations-0.4.19.tgz#53f50aeb022996963f89f59560d7b4cf801869da" @@ -1322,6 +1401,18 @@ resolved "https://registry.yarnpkg.com/@firebase/messaging-types/-/messaging-types-0.5.0.tgz#c5d0ef309ced1758fda93ef3ac70a786de2e73c4" integrity sha512-QaaBswrU6umJYb/ZYvjR5JDSslCGOH6D9P136PhabFAHLTR4TWjsaACvbBXuvwrfCXu10DtcjMxqfhdNIB1Xfg== +"@firebase/messaging@0.7.1": + version "0.7.1" + resolved "https://registry.yarnpkg.com/@firebase/messaging/-/messaging-0.7.1.tgz#debbe7eb17c5b789231da6c166c506e19ecf1ed4" + integrity sha512-iev/ST9v0xd/8YpGYrZtDcqdD9J6ZWzSuceRn8EKy5vIgQvW/rk2eTQc8axzvDpQ36ZfphMYuhW6XuNrR3Pd2Q== + dependencies: + "@firebase/component" "0.1.19" + "@firebase/installations" "0.4.17" + "@firebase/messaging-types" "0.5.0" + "@firebase/util" "0.3.2" + idb "3.0.2" + tslib "^1.11.1" + "@firebase/messaging@0.7.3": version "0.7.3" resolved "https://registry.yarnpkg.com/@firebase/messaging/-/messaging-0.7.3.tgz#31dded892455e4d0680e1452ff2fbfdfb9e4ce9b" @@ -1339,6 +1430,18 @@ resolved "https://registry.yarnpkg.com/@firebase/performance-types/-/performance-types-0.0.13.tgz#58ce5453f57e34b18186f74ef11550dfc558ede6" integrity sha512-6fZfIGjQpwo9S5OzMpPyqgYAUZcFzZxHFqOyNtorDIgNXq33nlldTL/vtaUZA8iT9TT5cJlCrF/jthKU7X21EA== +"@firebase/performance@0.4.2": + version "0.4.2" + resolved "https://registry.yarnpkg.com/@firebase/performance/-/performance-0.4.2.tgz#d5f134674b429d095ce0edfb50fcb4ab279c3cbe" + integrity sha512-irHTCVWJ/sxJo0QHg+yQifBeVu8ZJPihiTqYzBUz/0AGc51YSt49FZwqSfknvCN2+OfHaazz/ARVBn87g7Ex8g== + dependencies: + "@firebase/component" "0.1.19" + "@firebase/installations" "0.4.17" + "@firebase/logger" "0.2.6" + "@firebase/performance-types" "0.0.13" + "@firebase/util" "0.3.2" + tslib "^1.11.1" + "@firebase/performance@0.4.4": version "0.4.4" resolved "https://registry.yarnpkg.com/@firebase/performance/-/performance-0.4.4.tgz#5f13ea3b9a72a0ae9c36520c419be31448a0955a" @@ -1365,6 +1468,18 @@ resolved "https://registry.yarnpkg.com/@firebase/remote-config-types/-/remote-config-types-0.1.9.tgz#fe6bbe4d08f3b6e92fce30e4b7a9f4d6a96d6965" integrity sha512-G96qnF3RYGbZsTRut7NBX0sxyczxt1uyCgXQuH/eAfUCngxjEGcZQnBdy6mvSdqdJh5mC31rWPO4v9/s7HwtzA== +"@firebase/remote-config@0.1.28": + version "0.1.28" + resolved "https://registry.yarnpkg.com/@firebase/remote-config/-/remote-config-0.1.28.tgz#1c39916446f1ed82b4c07e556455bd232fcfd8e1" + integrity sha512-4zSdyxpt94jAnFhO8toNjG8oMKBD+xTuBIcK+Nw8BdQWeJhEamgXlupdBARUk1uf3AvYICngHH32+Si/dMVTbw== + dependencies: + "@firebase/component" "0.1.19" + "@firebase/installations" "0.4.17" + "@firebase/logger" "0.2.6" + "@firebase/remote-config-types" "0.1.9" + "@firebase/util" "0.3.2" + tslib "^1.11.1" + "@firebase/remote-config@0.1.30": version "0.1.30" resolved "https://registry.yarnpkg.com/@firebase/remote-config/-/remote-config-0.1.30.tgz#2cd6bbbed526a98b154e13a2cc73e748a77d7c3d" @@ -1382,10 +1497,20 @@ resolved "https://registry.yarnpkg.com/@firebase/storage-types/-/storage-types-0.3.13.tgz#cd43e939a2ab5742e109eb639a313673a48b5458" integrity sha512-pL7b8d5kMNCCL0w9hF7pr16POyKkb3imOW7w0qYrhBnbyJTdVxMWZhb0HxCFyQWC0w3EiIFFmxoz8NTFZDEFog== -"@firebase/storage@0.4.1": - version "0.4.1" - resolved "https://registry.yarnpkg.com/@firebase/storage/-/storage-0.4.1.tgz#b86973a8ab3ef52f38d6463fcc7613f5801ff8e4" - integrity sha512-/l05Dn3UYynPELt0ZFJz24H49sQ8c8KnOEGR/Pk1AOjLmc71vjjobVEkgkHyy1eyfmYuAZtsc6ePOwc89YnBTg== +"@firebase/storage@0.3.43": + version "0.3.43" + resolved "https://registry.yarnpkg.com/@firebase/storage/-/storage-0.3.43.tgz#107fb5db2eff2561b5c4e35ee4cbff48f28c7e77" + integrity sha512-Jp54jcuyimLxPhZHFVAhNbQmgTu3Sda7vXjXrNpPEhlvvMSq4yuZBR6RrZxe/OrNVprLHh/6lTCjwjOVSo3bWA== + dependencies: + "@firebase/component" "0.1.19" + "@firebase/storage-types" "0.3.13" + "@firebase/util" "0.3.2" + tslib "^1.11.1" + +"@firebase/storage@0.4.2": + version "0.4.2" + resolved "https://registry.yarnpkg.com/@firebase/storage/-/storage-0.4.2.tgz#bc5924b87bd2fdd4ab0de49851c0125ebc236b89" + integrity sha512-87CrvKrf8kijVekRBmUs8htsNz7N5X/pDhv3BvJBqw8K65GsUolpyjx0f4QJRkCRUYmh3MSkpa5P08lpVbC6nQ== dependencies: "@firebase/component" "0.1.21" "@firebase/storage-types" "0.3.13" @@ -1411,6 +1536,11 @@ resolved "https://registry.yarnpkg.com/@firebase/webchannel-wrapper/-/webchannel-wrapper-0.4.0.tgz#becce788818d3f47f0ac1a74c3c061ac1dcf4f6d" integrity sha512-8cUA/mg0S+BxIZ72TdZRsXKBP5n5uRcE3k29TZhZw6oIiHBt9JA7CTb/4pE1uKtE/q5NeTY2tBDcagoZ+1zjXQ== +"@firebase/webchannel-wrapper@0.4.1": + version "0.4.1" + resolved "https://registry.yarnpkg.com/@firebase/webchannel-wrapper/-/webchannel-wrapper-0.4.1.tgz#600f2275ff54739ad5ac0102f1467b8963cd5f71" + integrity sha512-0yPjzuzGMkW1GkrC8yWsiN7vt1OzkMIi9HgxRmKREZl2wnNPOKo/yScTjXf/O57HM8dltqxPF6jlNLFVtc2qdw== + "@google-cloud/common@^2.1.1": version "2.4.0" resolved "https://registry.yarnpkg.com/@google-cloud/common/-/common-2.4.0.tgz#2783b7de8435024a31453510f2dab5a6a91a4c82" @@ -5877,24 +6007,44 @@ firebase-tools@^8.0.0: winston "^3.0.0" ws "^7.2.3" -"firebase@^7.0.0 || ^8.0.0": - version "8.0.1" - resolved "https://registry.yarnpkg.com/firebase/-/firebase-8.0.1.tgz#24836c654c8577abd640439a5f1bc707bbd9f236" - integrity sha512-7QQKw+ycoR3LhMlxhPM+ND1F2Fx1eDlf3E55xYbmooxFW1t0p94HNENBc3JZytR1H0VoG9nSm2QEHsdr/Ca1Rg== +firebase7@^7.0: + version "7.24.0" + resolved "https://registry.yarnpkg.com/firebase/-/firebase-7.24.0.tgz#dab53b9c0f1c9538d2d6f4f51769897b0b6d60d8" + integrity sha512-j6jIyGFFBlwWAmrlUg9HyQ/x+YpsPkc/TTkbTyeLwwAJrpAmmEHNPT6O9xtAnMV4g7d3RqLL/u9//aZlbY4rQA== + dependencies: + "@firebase/analytics" "0.6.0" + "@firebase/app" "0.6.11" + "@firebase/app-types" "0.6.1" + "@firebase/auth" "0.15.0" + "@firebase/database" "0.6.13" + "@firebase/firestore" "1.18.0" + "@firebase/functions" "0.5.1" + "@firebase/installations" "0.4.17" + "@firebase/messaging" "0.7.1" + "@firebase/performance" "0.4.2" + "@firebase/polyfill" "0.3.36" + "@firebase/remote-config" "0.1.28" + "@firebase/storage" "0.3.43" + "@firebase/util" "0.3.2" + +"firebase@^7.0 || ^8.0": + version "8.1.1" + resolved "https://registry.yarnpkg.com/firebase/-/firebase-8.1.1.tgz#379094b724053931fda1086e9020a17b578e50d5" + integrity sha512-w1plr2jYvzBkx/rHE6A0EJf9318ufA5omShLuGocPlQtrvphel+KJcd+R02outE5E2lSDhyM0l3EoiA0YCD4hA== dependencies: "@firebase/analytics" "0.6.2" "@firebase/app" "0.6.13" "@firebase/app-types" "0.6.1" - "@firebase/auth" "0.15.1" - "@firebase/database" "0.7.1" - "@firebase/firestore" "2.0.1" + "@firebase/auth" "0.15.2" + "@firebase/database" "0.8.1" + "@firebase/firestore" "2.0.4" "@firebase/functions" "0.6.1" "@firebase/installations" "0.4.19" "@firebase/messaging" "0.7.3" "@firebase/performance" "0.4.4" "@firebase/polyfill" "0.3.36" "@firebase/remote-config" "0.1.30" - "@firebase/storage" "0.4.1" + "@firebase/storage" "0.4.2" "@firebase/util" "0.3.4" flat-arguments@^1.0.0: From 7fd44e70b40a8836936465c183e5e6398339207e Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 11:21:50 -0500 Subject: [PATCH 10/15] Try cached rather than offline --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f67d7e2cb..98b99d336 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -87,7 +87,7 @@ jobs: yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - name: Bump Firebase - run: yarn add firebase@^${{ matrix.firebase }}.0 --offline + run: yarn add firebase@^${{ matrix.firebase }}.0 --cached - name: Firebase emulator cache uses: actions/cache@v2 with: @@ -135,7 +135,7 @@ jobs: yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - name: Bump Firebase - run: yarn add firebase@^${{ matrix.firebase }}.0 --offline + run: yarn add firebase@^${{ matrix.firebase }}.0 --cached - name: Firebase emulator cache uses: actions/cache@v2 with: From 8ed76c595be50f520c553be447e9ec4a8cc9fea2 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 11:36:35 -0500 Subject: [PATCH 11/15] v7 vs. v8 have their own cache --- .github/workflows/test.yml | 24 ++--- package.json | 2 - yarn.lock | 176 +++---------------------------------- 3 files changed, 27 insertions(+), 175 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 98b99d336..693d26a04 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -26,8 +26,10 @@ jobs: id: node_modules_cache with: path: ./node_modules - key: ${{ runner.os }}-14-node_modules-${{ hashFiles('yarn.lock') }} - restore-keys: ${{ runner.os }}-14-node_modules- + key: ${{ runner.os }}-14-8-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: | + ${{ runner.os }}-14-8-node_modules- + ${{ runner.os }}-14-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 @@ -72,8 +74,10 @@ jobs: uses: actions/cache@v2 with: path: ./node_modules - key: ${{ runner.os }}-${{ matrix.node }}-node_modules-${{ hashFiles('yarn.lock') }} - restore-keys: ${{ runner.os }}-${{ matrix.node }}-node_modules- + key: ${{ runner.os }}-${{ matrix.node }}-${{ matrix.firebase }}-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: | + ${{ runner.os }}-${{ matrix.node }}-${{ matrix.firebase }}-node_modules- + ${{ runner.os }}-${{ matrix.node }}-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 @@ -86,8 +90,7 @@ jobs: run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - - name: Bump Firebase - run: yarn add firebase@^${{ matrix.firebase }}.0 --cached + yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline - name: Firebase emulator cache uses: actions/cache@v2 with: @@ -120,8 +123,10 @@ jobs: uses: actions/cache@v2 with: path: ./node_modules - key: ${{ runner.os }}-14-node_modules-${{ hashFiles('yarn.lock') }} - restore-keys: ${{ runner.os }}-14-node_modules- + key: ${{ runner.os }}-14-${{ matrix.firebase }}-node_modules-${{ hashFiles('yarn.lock') }} + restore-keys: | + ${{ runner.os }}-14-${{ matrix.firebase }}-node_modules- + ${{ runner.os }}-14-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 @@ -134,8 +139,7 @@ jobs: run: | yarn config set yarn-offline-mirror ~/.npm-packages-offline-cache yarn install --frozen-lockfile --prefer-offline - - name: Bump Firebase - run: yarn add firebase@^${{ matrix.firebase }}.0 --cached + yarn add firebase@^${{ matrix.firebase }}.0 --prefer-offline - name: Firebase emulator cache uses: actions/cache@v2 with: diff --git a/package.json b/package.json index cba3108bc..4afb99a7e 100644 --- a/package.json +++ b/package.json @@ -53,7 +53,6 @@ "firebase-admin": "^8.10.0", "firebase-functions": "^3.6.0", "firebase-tools": "^8.0.0", - "firebase7": "^7.0", "fs-extra": "^8.0.1", "fuzzy": "^0.1.3", "husky": "^4.2.5", @@ -79,7 +78,6 @@ "@angular/cli": "^9.0.0 || ^10.0.0 || ^11.0.0", "@angular/compiler-cli": "^9.0.0 || ^10.0.0 || ^11.0.0", "@angular/platform-server": "^9.0.0 || ^10.0.0 || ^11.0.0", - "@firebase/app-types": "^0.6.1", "@types/fs-extra": "^7.0.0", "@types/gzip-size": "^5.1.1", "@types/inquirer": "^0.0.44", diff --git a/yarn.lock b/yarn.lock index df3b697d5..04bfc178c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1157,18 +1157,6 @@ resolved "https://registry.yarnpkg.com/@firebase/analytics-types/-/analytics-types-0.4.0.tgz#d6716f9fa36a6e340bc0ecfe68af325aa6f60508" integrity sha512-Jj2xW+8+8XPfWGkv9HPv/uR+Qrmq37NPYT352wf7MvE9LrstpLVmFg3LqG6MCRr5miLAom5sen2gZ+iOhVDeRA== -"@firebase/analytics@0.6.0": - version "0.6.0" - resolved "https://registry.yarnpkg.com/@firebase/analytics/-/analytics-0.6.0.tgz#49f508d3f9f419f08c503f1171ef5fa1c3ba52eb" - integrity sha512-6qYEOPUVYrMhqvJ46Z5Uf1S4uULd6d7vGpMP5Qz+u8kIWuOQGcPdJKQap+Hla6Rq164or9gC2HRXuYXKlgWfpw== - dependencies: - "@firebase/analytics-types" "0.4.0" - "@firebase/component" "0.1.19" - "@firebase/installations" "0.4.17" - "@firebase/logger" "0.2.6" - "@firebase/util" "0.3.2" - tslib "^1.11.1" - "@firebase/analytics@0.6.2": version "0.6.2" resolved "https://registry.yarnpkg.com/@firebase/analytics/-/analytics-0.6.2.tgz#7f45675a1b524fff4d9e9fe318fd6e2ed067a325" @@ -1181,24 +1169,11 @@ "@firebase/util" "0.3.4" tslib "^1.11.1" -"@firebase/app-types@0.6.1", "@firebase/app-types@^0.6.1": +"@firebase/app-types@0.6.1": version "0.6.1" resolved "https://registry.yarnpkg.com/@firebase/app-types/-/app-types-0.6.1.tgz#dcbd23030a71c0c74fc95d4a3f75ba81653850e9" integrity sha512-L/ZnJRAq7F++utfuoTKX4CLBG5YR7tFO3PLzG1/oXXKEezJ0kRL3CMRoueBEmTCzVb/6SIs2Qlaw++uDgi5Xyg== -"@firebase/app@0.6.11": - version "0.6.11" - resolved "https://registry.yarnpkg.com/@firebase/app/-/app-0.6.11.tgz#f73f9e4571ba62f4029d8f9c9880a97e5a94eb1d" - integrity sha512-FH++PaoyTzfTAVuJ0gITNYEIcjT5G+D0671La27MU8Vvr6MTko+5YUZ4xS9QItyotSeRF4rMJ1KR7G8LSyySiA== - dependencies: - "@firebase/app-types" "0.6.1" - "@firebase/component" "0.1.19" - "@firebase/logger" "0.2.6" - "@firebase/util" "0.3.2" - dom-storage "2.1.0" - tslib "^1.11.1" - xmlhttprequest "1.8.0" - "@firebase/app@0.6.13": version "0.6.13" resolved "https://registry.yarnpkg.com/@firebase/app/-/app-0.6.13.tgz#f2e9fa9e75815e54161dc34659a60f1fffd9a450" @@ -1222,13 +1197,6 @@ resolved "https://registry.yarnpkg.com/@firebase/auth-types/-/auth-types-0.10.1.tgz#7815e71c9c6f072034415524b29ca8f1d1770660" integrity sha512-/+gBHb1O9x/YlG7inXfxff/6X3BPZt4zgBv4kql6HEmdzNQCodIRlEYnI+/da+lN+dha7PjaFH7C7ewMmfV7rw== -"@firebase/auth@0.15.0": - version "0.15.0" - resolved "https://registry.yarnpkg.com/@firebase/auth/-/auth-0.15.0.tgz#45d6def6d6d9444432c005710df442991828275f" - integrity sha512-IFuzhxS+HtOQl7+SZ/Mhaghy/zTU7CENsJFWbC16tv2wfLZbayKF5jYGdAU3VFLehgC8KjlcIWd10akc3XivfQ== - dependencies: - "@firebase/auth-types" "0.10.1" - "@firebase/auth@0.15.2": version "0.15.2" resolved "https://registry.yarnpkg.com/@firebase/auth/-/auth-0.15.2.tgz#9ada3f37620d131a1c56994138a599b5c9f9ca2e" @@ -1266,19 +1234,6 @@ dependencies: "@firebase/app-types" "0.6.1" -"@firebase/database@0.6.13", "@firebase/database@^0.6.0": - version "0.6.13" - resolved "https://registry.yarnpkg.com/@firebase/database/-/database-0.6.13.tgz#b96fe0c53757dd6404ee085fdcb45c0f9f525c17" - integrity sha512-NommVkAPzU7CKd1gyehmi3lz0K78q0KOfiex7Nfy7MBMwknLm7oNqKovXSgQV1PCLvKXvvAplDSFhDhzIf9obA== - dependencies: - "@firebase/auth-interop-types" "0.1.5" - "@firebase/component" "0.1.19" - "@firebase/database-types" "0.5.2" - "@firebase/logger" "0.2.6" - "@firebase/util" "0.3.2" - faye-websocket "0.11.3" - tslib "^1.11.1" - "@firebase/database@0.8.1": version "0.8.1" resolved "https://registry.yarnpkg.com/@firebase/database/-/database-0.8.1.tgz#a7bc1c01052d35817a242c21bfe09ab29ee485a3" @@ -1292,31 +1247,24 @@ faye-websocket "0.11.3" tslib "^1.11.1" -"@firebase/firestore-types@1.14.0": - version "1.14.0" - resolved "https://registry.yarnpkg.com/@firebase/firestore-types/-/firestore-types-1.14.0.tgz#4516249d3c181849fd3c856831944dbd5c8c55fc" - integrity sha512-WF8IBwHzZDhwyOgQnmB0pheVrLNP78A8PGxk1nxb/Nrgh1amo4/zYvFMGgSsTeaQK37xMYS/g7eS948te/dJxw== - -"@firebase/firestore-types@2.0.0": - version "2.0.0" - resolved "https://registry.yarnpkg.com/@firebase/firestore-types/-/firestore-types-2.0.0.tgz#1f6212553b240f1a8905bb8dcf1f87769138c5c0" - integrity sha512-ZGb7p1SSQJP0Z+kc9GAUi+Fx5rJatFddBrS1ikkayW+QHfSIz0omU23OgSHcBGTxe8dJCeKiKA2Yf+tkDKO/LA== - -"@firebase/firestore@1.18.0": - version "1.18.0" - resolved "https://registry.yarnpkg.com/@firebase/firestore/-/firestore-1.18.0.tgz#3430e8c60d3e6be1d174b3a258838b1944c93a4d" - integrity sha512-maMq4ltkrwjDRusR2nt0qS4wldHQMp+0IDSfXIjC+SNmjnWY/t/+Skn9U3Po+dB38xpz3i7nsKbs+8utpDnPSw== +"@firebase/database@^0.6.0": + version "0.6.13" + resolved "https://registry.yarnpkg.com/@firebase/database/-/database-0.6.13.tgz#b96fe0c53757dd6404ee085fdcb45c0f9f525c17" + integrity sha512-NommVkAPzU7CKd1gyehmi3lz0K78q0KOfiex7Nfy7MBMwknLm7oNqKovXSgQV1PCLvKXvvAplDSFhDhzIf9obA== dependencies: + "@firebase/auth-interop-types" "0.1.5" "@firebase/component" "0.1.19" - "@firebase/firestore-types" "1.14.0" + "@firebase/database-types" "0.5.2" "@firebase/logger" "0.2.6" "@firebase/util" "0.3.2" - "@firebase/webchannel-wrapper" "0.4.0" - "@grpc/grpc-js" "^1.0.0" - "@grpc/proto-loader" "^0.5.0" - node-fetch "2.6.1" + faye-websocket "0.11.3" tslib "^1.11.1" +"@firebase/firestore-types@2.0.0": + version "2.0.0" + resolved "https://registry.yarnpkg.com/@firebase/firestore-types/-/firestore-types-2.0.0.tgz#1f6212553b240f1a8905bb8dcf1f87769138c5c0" + integrity sha512-ZGb7p1SSQJP0Z+kc9GAUi+Fx5rJatFddBrS1ikkayW+QHfSIz0omU23OgSHcBGTxe8dJCeKiKA2Yf+tkDKO/LA== + "@firebase/firestore@2.0.4": version "2.0.4" resolved "https://registry.yarnpkg.com/@firebase/firestore/-/firestore-2.0.4.tgz#c4be6f3540f607fd8e200cfba83c4997c29447fe" @@ -1332,27 +1280,11 @@ node-fetch "2.6.1" tslib "^1.11.1" -"@firebase/functions-types@0.3.17": - version "0.3.17" - resolved "https://registry.yarnpkg.com/@firebase/functions-types/-/functions-types-0.3.17.tgz#348bf5528b238eeeeeae1d52e8ca547b21d33a94" - integrity sha512-DGR4i3VI55KnYk4IxrIw7+VG7Q3gA65azHnZxo98Il8IvYLr2UTBlSh72dTLlDf25NW51HqvJgYJDKvSaAeyHQ== - "@firebase/functions-types@0.4.0": version "0.4.0" resolved "https://registry.yarnpkg.com/@firebase/functions-types/-/functions-types-0.4.0.tgz#0b789f4fe9a9c0b987606c4da10139345b40f6b9" integrity sha512-3KElyO3887HNxtxNF1ytGFrNmqD+hheqjwmT3sI09FaDCuaxGbOnsXAXH2eQ049XRXw9YQpHMgYws/aUNgXVyQ== -"@firebase/functions@0.5.1": - version "0.5.1" - resolved "https://registry.yarnpkg.com/@firebase/functions/-/functions-0.5.1.tgz#fa0568bdcdf7dfa7e5f4f66c1e06e376dc7e25b6" - integrity sha512-yyjPZXXvzFPjkGRSqFVS5Hc2Y7Y48GyyMH+M3i7hLGe69r/59w6wzgXKqTiSYmyE1pxfjxU4a1YqBDHNkQkrYQ== - dependencies: - "@firebase/component" "0.1.19" - "@firebase/functions-types" "0.3.17" - "@firebase/messaging-types" "0.5.0" - node-fetch "2.6.1" - tslib "^1.11.1" - "@firebase/functions@0.6.1": version "0.6.1" resolved "https://registry.yarnpkg.com/@firebase/functions/-/functions-0.6.1.tgz#32640b8f877637057dfaaeb122be8c8e99ad1af7" @@ -1369,17 +1301,6 @@ resolved "https://registry.yarnpkg.com/@firebase/installations-types/-/installations-types-0.3.4.tgz#589a941d713f4f64bf9f4feb7f463505bab1afa2" integrity sha512-RfePJFovmdIXb6rYwtngyxuEcWnOrzdZd9m7xAW0gRxDIjBT20n3BOhjpmgRWXo/DAxRmS7bRjWAyTHY9cqN7Q== -"@firebase/installations@0.4.17": - version "0.4.17" - resolved "https://registry.yarnpkg.com/@firebase/installations/-/installations-0.4.17.tgz#1367b721e2c6c4880646bbc4f257e8616986a004" - integrity sha512-AE/TyzIpwkC4UayRJD419xTqZkKzxwk0FLht3Dci8WI2OEKHSwoZG9xv4hOBZebe+fDzoV2EzfatQY8c/6Avig== - dependencies: - "@firebase/component" "0.1.19" - "@firebase/installations-types" "0.3.4" - "@firebase/util" "0.3.2" - idb "3.0.2" - tslib "^1.11.1" - "@firebase/installations@0.4.19": version "0.4.19" resolved "https://registry.yarnpkg.com/@firebase/installations/-/installations-0.4.19.tgz#53f50aeb022996963f89f59560d7b4cf801869da" @@ -1401,18 +1322,6 @@ resolved "https://registry.yarnpkg.com/@firebase/messaging-types/-/messaging-types-0.5.0.tgz#c5d0ef309ced1758fda93ef3ac70a786de2e73c4" integrity sha512-QaaBswrU6umJYb/ZYvjR5JDSslCGOH6D9P136PhabFAHLTR4TWjsaACvbBXuvwrfCXu10DtcjMxqfhdNIB1Xfg== -"@firebase/messaging@0.7.1": - version "0.7.1" - resolved "https://registry.yarnpkg.com/@firebase/messaging/-/messaging-0.7.1.tgz#debbe7eb17c5b789231da6c166c506e19ecf1ed4" - integrity sha512-iev/ST9v0xd/8YpGYrZtDcqdD9J6ZWzSuceRn8EKy5vIgQvW/rk2eTQc8axzvDpQ36ZfphMYuhW6XuNrR3Pd2Q== - dependencies: - "@firebase/component" "0.1.19" - "@firebase/installations" "0.4.17" - "@firebase/messaging-types" "0.5.0" - "@firebase/util" "0.3.2" - idb "3.0.2" - tslib "^1.11.1" - "@firebase/messaging@0.7.3": version "0.7.3" resolved "https://registry.yarnpkg.com/@firebase/messaging/-/messaging-0.7.3.tgz#31dded892455e4d0680e1452ff2fbfdfb9e4ce9b" @@ -1430,18 +1339,6 @@ resolved "https://registry.yarnpkg.com/@firebase/performance-types/-/performance-types-0.0.13.tgz#58ce5453f57e34b18186f74ef11550dfc558ede6" integrity sha512-6fZfIGjQpwo9S5OzMpPyqgYAUZcFzZxHFqOyNtorDIgNXq33nlldTL/vtaUZA8iT9TT5cJlCrF/jthKU7X21EA== -"@firebase/performance@0.4.2": - version "0.4.2" - resolved "https://registry.yarnpkg.com/@firebase/performance/-/performance-0.4.2.tgz#d5f134674b429d095ce0edfb50fcb4ab279c3cbe" - integrity sha512-irHTCVWJ/sxJo0QHg+yQifBeVu8ZJPihiTqYzBUz/0AGc51YSt49FZwqSfknvCN2+OfHaazz/ARVBn87g7Ex8g== - dependencies: - "@firebase/component" "0.1.19" - "@firebase/installations" "0.4.17" - "@firebase/logger" "0.2.6" - "@firebase/performance-types" "0.0.13" - "@firebase/util" "0.3.2" - tslib "^1.11.1" - "@firebase/performance@0.4.4": version "0.4.4" resolved "https://registry.yarnpkg.com/@firebase/performance/-/performance-0.4.4.tgz#5f13ea3b9a72a0ae9c36520c419be31448a0955a" @@ -1468,18 +1365,6 @@ resolved "https://registry.yarnpkg.com/@firebase/remote-config-types/-/remote-config-types-0.1.9.tgz#fe6bbe4d08f3b6e92fce30e4b7a9f4d6a96d6965" integrity sha512-G96qnF3RYGbZsTRut7NBX0sxyczxt1uyCgXQuH/eAfUCngxjEGcZQnBdy6mvSdqdJh5mC31rWPO4v9/s7HwtzA== -"@firebase/remote-config@0.1.28": - version "0.1.28" - resolved "https://registry.yarnpkg.com/@firebase/remote-config/-/remote-config-0.1.28.tgz#1c39916446f1ed82b4c07e556455bd232fcfd8e1" - integrity sha512-4zSdyxpt94jAnFhO8toNjG8oMKBD+xTuBIcK+Nw8BdQWeJhEamgXlupdBARUk1uf3AvYICngHH32+Si/dMVTbw== - dependencies: - "@firebase/component" "0.1.19" - "@firebase/installations" "0.4.17" - "@firebase/logger" "0.2.6" - "@firebase/remote-config-types" "0.1.9" - "@firebase/util" "0.3.2" - tslib "^1.11.1" - "@firebase/remote-config@0.1.30": version "0.1.30" resolved "https://registry.yarnpkg.com/@firebase/remote-config/-/remote-config-0.1.30.tgz#2cd6bbbed526a98b154e13a2cc73e748a77d7c3d" @@ -1497,16 +1382,6 @@ resolved "https://registry.yarnpkg.com/@firebase/storage-types/-/storage-types-0.3.13.tgz#cd43e939a2ab5742e109eb639a313673a48b5458" integrity sha512-pL7b8d5kMNCCL0w9hF7pr16POyKkb3imOW7w0qYrhBnbyJTdVxMWZhb0HxCFyQWC0w3EiIFFmxoz8NTFZDEFog== -"@firebase/storage@0.3.43": - version "0.3.43" - resolved "https://registry.yarnpkg.com/@firebase/storage/-/storage-0.3.43.tgz#107fb5db2eff2561b5c4e35ee4cbff48f28c7e77" - integrity sha512-Jp54jcuyimLxPhZHFVAhNbQmgTu3Sda7vXjXrNpPEhlvvMSq4yuZBR6RrZxe/OrNVprLHh/6lTCjwjOVSo3bWA== - dependencies: - "@firebase/component" "0.1.19" - "@firebase/storage-types" "0.3.13" - "@firebase/util" "0.3.2" - tslib "^1.11.1" - "@firebase/storage@0.4.2": version "0.4.2" resolved "https://registry.yarnpkg.com/@firebase/storage/-/storage-0.4.2.tgz#bc5924b87bd2fdd4ab0de49851c0125ebc236b89" @@ -1531,11 +1406,6 @@ dependencies: tslib "^1.11.1" -"@firebase/webchannel-wrapper@0.4.0": - version "0.4.0" - resolved "https://registry.yarnpkg.com/@firebase/webchannel-wrapper/-/webchannel-wrapper-0.4.0.tgz#becce788818d3f47f0ac1a74c3c061ac1dcf4f6d" - integrity sha512-8cUA/mg0S+BxIZ72TdZRsXKBP5n5uRcE3k29TZhZw6oIiHBt9JA7CTb/4pE1uKtE/q5NeTY2tBDcagoZ+1zjXQ== - "@firebase/webchannel-wrapper@0.4.1": version "0.4.1" resolved "https://registry.yarnpkg.com/@firebase/webchannel-wrapper/-/webchannel-wrapper-0.4.1.tgz#600f2275ff54739ad5ac0102f1467b8963cd5f71" @@ -6007,26 +5877,6 @@ firebase-tools@^8.0.0: winston "^3.0.0" ws "^7.2.3" -firebase7@^7.0: - version "7.24.0" - resolved "https://registry.yarnpkg.com/firebase/-/firebase-7.24.0.tgz#dab53b9c0f1c9538d2d6f4f51769897b0b6d60d8" - integrity sha512-j6jIyGFFBlwWAmrlUg9HyQ/x+YpsPkc/TTkbTyeLwwAJrpAmmEHNPT6O9xtAnMV4g7d3RqLL/u9//aZlbY4rQA== - dependencies: - "@firebase/analytics" "0.6.0" - "@firebase/app" "0.6.11" - "@firebase/app-types" "0.6.1" - "@firebase/auth" "0.15.0" - "@firebase/database" "0.6.13" - "@firebase/firestore" "1.18.0" - "@firebase/functions" "0.5.1" - "@firebase/installations" "0.4.17" - "@firebase/messaging" "0.7.1" - "@firebase/performance" "0.4.2" - "@firebase/polyfill" "0.3.36" - "@firebase/remote-config" "0.1.28" - "@firebase/storage" "0.3.43" - "@firebase/util" "0.3.2" - "firebase@^7.0 || ^8.0": version "8.1.1" resolved "https://registry.yarnpkg.com/firebase/-/firebase-8.1.1.tgz#379094b724053931fda1086e9020a17b578e50d5" From 1117e14e75d404633ef2f3dcf8ac05f62b7a5c4f Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 11:52:41 -0500 Subject: [PATCH 12/15] Attempting to get Node 10 tests green --- package.json | 1 + tools/jasmine.js | 2 ++ yarn.lock | 7 +++++++ 3 files changed, 10 insertions(+) diff --git a/package.json b/package.json index 4afb99a7e..63864cec2 100644 --- a/package.json +++ b/package.json @@ -89,6 +89,7 @@ "concurrently": "^2.2.0", "conventional-changelog-cli": "^1.2.0", "firebase-functions-test": "^0.2.2", + "globalthis": "^1.0.1", "gzip-size": "^5.1.1", "jasmine": "^3.4.0", "jasmine-core": "~3.5.0", diff --git a/tools/jasmine.js b/tools/jasmine.js index dd9650197..3e0a3b1f9 100644 --- a/tools/jasmine.js +++ b/tools/jasmine.js @@ -21,6 +21,8 @@ require('zone.js/dist/task-tracking'); const { getTestBed } = require('@angular/core/testing'); const { platformServerTesting, ServerTestingModule } = require('@angular/platform-server/testing'); +var globalThis = require('globalthis/polyfill')(); + // First, initialize the Angular testing environment. getTestBed().initTestEnvironment( ServerTestingModule, diff --git a/yarn.lock b/yarn.lock index 04bfc178c..86f6d94fa 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6359,6 +6359,13 @@ globals@^9.18.0: resolved "https://registry.yarnpkg.com/globals/-/globals-9.18.0.tgz#aa3896b3e69b487f17e31ed2143d69a8e30c2d8a" integrity sha512-S0nG3CLEQiY/ILxqtztTWH/3iRRdyBLw6KMDxnKMchrtbj2OFmehVh0WUCfW3DUrIgx/qFrJPICrq4Z4sTR9UQ== +globalthis@^1.0.1: + version "1.0.1" + resolved "https://registry.yarnpkg.com/globalthis/-/globalthis-1.0.1.tgz#40116f5d9c071f9e8fb0037654df1ab3a83b7ef9" + integrity sha512-mJPRTc/P39NH/iNG4mXa9aIhNymaQikTrnspeCa2ZuJ+mH2QN/rXwtX3XwKrHqWgUQFbNZKtHM105aHzJalElw== + dependencies: + define-properties "^1.1.3" + globby@^11.0.1: version "11.0.1" resolved "https://registry.yarnpkg.com/globby/-/globby-11.0.1.tgz#9a2bf107a068f3ffeabc49ad702c79ede8cfd357" From ad0d7e564ff910336010a6c22973f8d42e59bd15 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 12:09:37 -0500 Subject: [PATCH 13/15] globalGlobalGlobalGlobalThis --- .github/workflows/test.yml | 3 +++ tools/jasmine.js | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 693d26a04..f3c70cc36 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -30,6 +30,7 @@ jobs: restore-keys: | ${{ runner.os }}-14-8-node_modules- ${{ runner.os }}-14-node_modules- + ${{ runner.os }}-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 @@ -78,6 +79,7 @@ jobs: restore-keys: | ${{ runner.os }}-${{ matrix.node }}-${{ matrix.firebase }}-node_modules- ${{ runner.os }}-${{ matrix.node }}-node_modules- + ${{ runner.os }}-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 @@ -127,6 +129,7 @@ jobs: restore-keys: | ${{ runner.os }}-14-${{ matrix.firebase }}-node_modules- ${{ runner.os }}-14-node_modules- + ${{ runner.os }}-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 diff --git a/tools/jasmine.js b/tools/jasmine.js index 3e0a3b1f9..d06a165c5 100644 --- a/tools/jasmine.js +++ b/tools/jasmine.js @@ -21,7 +21,7 @@ require('zone.js/dist/task-tracking'); const { getTestBed } = require('@angular/core/testing'); const { platformServerTesting, ServerTestingModule } = require('@angular/platform-server/testing'); -var globalThis = require('globalthis/polyfill')(); +global['globalThis'] = require('globalthis/polyfill')(); // First, initialize the Angular testing environment. getTestBed().initTestEnvironment( From d096420bb20c658b5addc2eb406422e18c35de36 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 12:16:55 -0500 Subject: [PATCH 14/15] Dont fail fast, good to see other failures rather than aborts --- .github/workflows/test.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f3c70cc36..0b321fb74 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -30,7 +30,6 @@ jobs: restore-keys: | ${{ runner.os }}-14-8-node_modules- ${{ runner.os }}-14-node_modules- - ${{ runner.os }}-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 @@ -61,6 +60,7 @@ jobs: matrix: node: ["10", "12", "14"] firebase: ["7", "8"] + fail-fast: false name: Test Firebase v${{ matrix.firebase }} on Node.js ${{ matrix.node }} steps: - name: Checkout @@ -79,7 +79,6 @@ jobs: restore-keys: | ${{ runner.os }}-${{ matrix.node }}-${{ matrix.firebase }}-node_modules- ${{ runner.os }}-${{ matrix.node }}-node_modules- - ${{ runner.os }}-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 @@ -129,7 +128,6 @@ jobs: restore-keys: | ${{ runner.os }}-14-${{ matrix.firebase }}-node_modules- ${{ runner.os }}-14-node_modules- - ${{ runner.os }}-node_modules- - name: Yarn offline cache if: steps.node_modules_cache.outputs.cache-hit != 'true' uses: actions/cache@v2 From 8968f73a9856df3b9713a6b4a2be31f23f2f9002 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 3 Dec 2020 12:18:04 -0500 Subject: [PATCH 15/15] Same for browser tests --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0b321fb74..2da3e8ab6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -111,6 +111,7 @@ jobs: strategy: matrix: firebase: ["7", "8"] + fail-fast: false steps: - name: Checkout uses: actions/checkout@v2