Skip to content

Commit 750737c

Browse files
cartantdavideast
authored andcommitted
fix(database): Fix test TypeScript errors
Closes #875
1 parent 2d80cde commit 750737c

File tree

2 files changed

+11
-17
lines changed

2 files changed

+11
-17
lines changed

src/database/firebase_list_factory.spec.ts

+9-15
Original file line numberDiff line numberDiff line change
@@ -759,19 +759,17 @@ describe('FirebaseListFactory', () => {
759759
startAt: { value: 0 }
760760
}
761761
});
762-
query1 = take.call(query1, 1);
763-
query1 = toPromise.call(query1);
762+
let promise1 = toPromise.call(take.call(query1, 1));
764763

765764
let query2 = FirebaseListFactory(`questions`, {
766765
query: {
767766
orderByChild: 'data',
768767
startAt: { value: 0, key: 'val2' }
769768
}
770769
});
771-
query2 = take.call(query2, 1);
772-
query2 = toPromise.call(query2);
770+
let promise2 = toPromise.call(take.call(query2, 1));
773771

774-
Promise.all([query1, query2]).then(([list1, list2]) => {
772+
Promise.all([promise1, promise2]).then(([list1, list2]) => {
775773
expect(list1.map(i => i.$key)).toEqual(['val1', 'val2', 'val3']);
776774
expect(list2.map(i => i.$key)).toEqual(['val2', 'val3']);
777775
done();
@@ -799,19 +797,17 @@ describe('FirebaseListFactory', () => {
799797
equalTo: { value: 0 }
800798
}
801799
});
802-
query1 = take.call(query1, 1);
803-
query1 = toPromise.call(query1);
800+
let promise1 = toPromise.call(take.call(query1, 1));
804801

805802
let query2 = FirebaseListFactory(`questions`, {
806803
query: {
807804
orderByChild: 'data',
808805
equalTo: { value: 0, key: 'val2' }
809806
}
810807
});
811-
query2 = take.call(query2, 1);
812-
query2 = toPromise.call(query2);
808+
let promise2 = toPromise.call(take.call(query2, 1));
813809

814-
Promise.all([query1, query2]).then(([list1, list2]) => {
810+
Promise.all([promise1, promise2]).then(([list1, list2]) => {
815811
expect(list1.map(i => i.$key)).toEqual(['val1', 'val2', 'val3']);
816812
expect(list2.map(i => i.$key)).toEqual(['val2']);
817813
done();
@@ -839,19 +835,17 @@ describe('FirebaseListFactory', () => {
839835
endAt: { value: 0 }
840836
}
841837
});
842-
query1 = take.call(query1, 1);
843-
query1 = toPromise.call(query1);
838+
let promise1 = toPromise.call(take.call(query1, 1));
844839

845840
let query2 = FirebaseListFactory(`questions`, {
846841
query: {
847842
orderByChild: 'data',
848843
endAt: { value: 0, key: 'val2' }
849844
}
850845
});
851-
query2 = take.call(query2, 1);
852-
query2 = toPromise.call(query2);
846+
let promise2 = toPromise.call(take.call(query2, 1));
853847

854-
Promise.all([query1, query2]).then(([list1, list2]) => {
848+
Promise.all([promise1, promise2]).then(([list1, list2]) => {
855849
expect(list1.map(i => i.$key)).toEqual(['val1', 'val2', 'val3']);
856850
expect(list2.map(i => i.$key)).toEqual(['val1', 'val2']);
857851
done();

src/database/query_observable.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { Observable } from 'rxjs/Observable';
22
import { Observer } from 'rxjs/Observer';
33
import { Subject } from 'rxjs/Subject';
4-
import { Query } from '../interfaces';
4+
import { Query, ScalarQuery } from '../interfaces';
55
import { getOrderObservables, observeQuery } from './index';
66

7-
function scalarQueryTest(query: Query, done: any) {
7+
function scalarQueryTest(query: ScalarQuery, done: any) {
88
const queryObservable = observeQuery(query);
99
queryObservable.subscribe(result => {
1010
expect(result).toEqual(query);

0 commit comments

Comments
 (0)