Skip to content

Commit f24df35

Browse files
authored
Removing the problematic share from the zone.js changes (#2315)
* Removing the problematic share from the zone.js changes * 5.4.1 & changelog entry * Dropping the cache and matrix from travis, as I have in master
1 parent 168077b commit f24df35

File tree

4 files changed

+15
-30
lines changed

4 files changed

+15
-30
lines changed

.travis.yml

+2-27
Original file line numberDiff line numberDiff line change
@@ -6,37 +6,12 @@ node_js:
66
addons:
77
chrome: stable
88

9-
cache:
10-
yarn: true
11-
directories:
12-
- node_modules
13-
- "$HOME/.npm"
14-
- "$HOME/.cache"
15-
16-
env:
17-
- CANARY=false
18-
- CANARY=true
19-
20-
matrix:
21-
fast_finish: true
22-
allow_failures:
23-
- env: CANARY=true
24-
259
branches:
2610
only:
2711
- master # otherwise pull requests get built twice
12+
- v5
2813

29-
install:
30-
- |
31-
if $CANARY; then
32-
yarn upgrade && yarn add firebase@canary
33-
else
34-
if [ "$TRAVIS_BRANCH" = "master" -a "$TRAVIS_PULL_REQUEST" = "false" ]; then
35-
yarn upgrade
36-
else
37-
yarn install --frozen-lockfile
38-
fi
39-
fi
14+
install: yarn install --frozen-lockfile
4015

4116
script:
4217
- yarn build

CHANGELOG.md

+9
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
<a name="5.4.2"></a>
2+
## [5.4.2](https://github.com/angular/angularfire2/compare/5.4.1...5.4.2) (2020-02-06)
3+
4+
5+
### Bug Fixes
6+
7+
* **core:** fixing a problem with hot/cold observables resulting in missed events ([#2315](https://github.com/angular/angularfire2/issues/2315)) ([6dd0409](https://github.com/angular/angularfire2/commit/6dd0409))
8+
9+
110
<a name="5.4.1"></a>
211
## [5.4.1](https://github.com/angular/angularfire2/compare/5.4.0...5.4.1) (2020-02-05)
312

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@angular/fire",
3-
"version": "5.4.1",
3+
"version": "5.4.2",
44
"description": "The official library of Firebase and Angular.",
55
"private": true,
66
"scripts": {

src/core/angularfire2.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,9 @@ export function ɵkeepUnstableUntilFirstFactory(
9090
// Run the subscribe body outside of Angular (e.g. calling Firebase SDK to add a listener to a change event)
9191
subscribeOn(schedulers.outsideAngular),
9292
// Run operators inside the angular zone (e.g. side effects via tap())
93-
observeOn(schedulers.insideAngular),
94-
share()
93+
observeOn(schedulers.insideAngular)
94+
// This isn't working correctly #2309, #2314, #2312
95+
// share()
9596
);
9697
}
9798
}

0 commit comments

Comments
 (0)