Skip to content

fix(core): empty and errors were blocking Universal rendering #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2018
Merged

fix(core): empty and errors were blocking Universal rendering #1832

merged 2 commits into from
Aug 23, 2018

Conversation

jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

  • For Universal and browser compatibility, use import rather than require for lazy messaging. Typescript isn't happy with it, so ignore for now.
  • Need to upgrade rollup to get support
  • empty() and errors were releasing the universal render block, clean that up

Code sample

@jamesdaniels jamesdaniels requested a review from davideast August 23, 2018 07:43
@jamesdaniels jamesdaniels force-pushed the empty_and_error_block_render branch from 85c9009 to 9e16b0e Compare August 23, 2018 17:24
@jamesdaniels jamesdaniels mentioned this pull request Aug 23, 2018
Closed
davideast
davideast approved these changes Aug 23, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideast davideast merged commit 36a8ff8 into master Aug 23, 2018
@davideast davideast deleted the empty_and_error_block_render branch August 23, 2018 18:35
sulco pushed a commit to sulco/angularfire2 that referenced this pull request Sep 3, 2018
@jamesdaniels @sulco
fix(core): empty and errors were blocking Universal rendering (angula…
0891a65 
…r#1832)

* fix(core): empty and errors were blocking Universal rendering

* fix(core): handle more than one emissions in keepUnstableUntilFirst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdaniels @davideast @googlebot