Skip to content

Commit 2ad62b4

Browse files
committed
s/side/position
1 parent 4f3823c commit 2ad62b4

File tree

7 files changed

+29
-30
lines changed

7 files changed

+29
-30
lines changed

src/demo-app/sidenav/sidenav-demo.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ <h2>Basic Use Case</h2>
1515
<input #myinput>
1616
</md-sidenav>
1717

18-
<md-sidenav #end side="end">
18+
<md-sidenav #end position="end">
1919
End Side Drawer
2020
<br>
2121
<button md-button (click)="end.close()">Close</button>
@@ -48,14 +48,14 @@ <h2>Sidenav Already Opened</h2>
4848
</div>
4949
</md-sidenav-container>
5050

51-
<h2>Dynamic Side Sidenav</h2>
51+
<h2>Dynamic Position Sidenav</h2>
5252

5353
<md-sidenav-container class="demo-sidenav-container">
54-
<md-sidenav #dynamicSideSidenav1 mode="side" [side]="invert ? 'end' : 'start'">Start</md-sidenav>
55-
<md-sidenav #dynamicSideSidenav2 mode="side" [side]="invert ? 'start' : 'end'">End</md-sidenav>
54+
<md-sidenav #dynamicPosSidenav1 mode="side" [position]="invert ? 'end' : 'start'">Start</md-sidenav>
55+
<md-sidenav #dynamicPosSidenav2 mode="side" [position]="invert ? 'start' : 'end'">End</md-sidenav>
5656

5757
<div class="demo-sidenav-content">
58-
<button (click)="dynamicSideSidenav1.toggle(); dynamicSideSidenav2.toggle()">
58+
<button (click)="dynamicPosSidenav1.toggle(); dynamicPosSidenav2.toggle()">
5959
Toggle sidenavs
6060
</button>
6161
<button (click)="invert = !invert">Change sides</button>

src/lib/sidenav/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ The sidenav panel.
2323

2424
| Name | Type | Description |
2525
| --- | --- | --- |
26-
| `side` | `"start"\|"end"` | The side of this sidenav. In LTR direction, `"start"` will be shown on the left, `"end"` on the right. In RTL, it is reversed. `"start"` is used by default. If there is more than 1 sidenav on either side the container will be considered invalid and none of the sidenavs will be visible or toggleable until the container is valid again. |
26+
| `position` | `"start"\|"end"` | The position of this sidenav. In LTR direction, `"start"` will be shown on the left, `"end"` on the right. In RTL, it is reversed. `"start"` is used by default. If there is more than 1 sidenav on either side the container will be considered invalid and none of the sidenavs will be visible or toggleable until the container is valid again. |
2727
| `mode` | `"over"\|"push"\|"side"` | The mode or styling of the sidenav, default being `"over"`. With `"over"` the sidenav will appear above the content, and a backdrop will be shown. With `"push"` the sidenav will push the content of the `<md-sidenav-container>` to the side, and show a backdrop over it. `"side"` will resize the content and keep the sidenav opened. Clicking the backdrop will close sidenavs that do not have `mode="side"`. |
2828
| `opened` | `boolean` | Whether or not the sidenav is opened. Use this binding to open/close the sidenav. |
2929

@@ -68,7 +68,7 @@ Here's a simple example of using the sidenav:
6868
<br>
6969
<button md-button #closeStartButton (click)="start.close()">Close</button>
7070
</md-sidenav>
71-
<md-sidenav #end side="end">
71+
<md-sidenav #end position="end">
7272
End Sidenav.
7373
<button md-button (click)="end.close()">Close</button>
7474
</md-sidenav>

src/lib/sidenav/drawer-container.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,3 @@
66
<div class="mat-drawer-content" [ngStyle]="_styles" cdk-scrollable>
77
<ng-content></ng-content>
88
</div>
9-
F

src/lib/sidenav/drawer.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,8 @@ class DrawerContainerNoDrawerTestApp { }
373373
@Component({
374374
template: `
375375
<md-drawer-container>
376-
<md-drawer side="start"> </md-drawer>
377-
<md-drawer side="end"> </md-drawer>
376+
<md-drawer [position]="start"></md-drawer>
377+
<md-drawer [position]="end"></md-drawer>
378378
</md-drawer-container>`,
379379
})
380380
class DrawerContainerTwoDrawerTestApp {
@@ -385,9 +385,9 @@ class DrawerContainerTwoDrawerTestApp {
385385
@Component({
386386
template: `
387387
<md-drawer-container (backdropClick)="backdropClicked()">
388-
<md-drawer #drawer side="start"
389-
(open)="open()"
390-
(close)="close()">
388+
<md-drawer #drawer [position]="start"
389+
(open)="open()"
390+
(close)="close()">
391391
<button #drawerButton>Content.</button>
392392
</md-drawer>
393393
<button (click)="drawer.open()" class="open" #openButton></button>
@@ -439,8 +439,8 @@ class DrawerSetToOpenedTrue { }
439439
@Component({
440440
template: `
441441
<md-drawer-container>
442-
<md-drawer #drawer1 [side]="drawer1Side"></md-drawer>
443-
<md-drawer #drawer2 [side]="drawer2Side"></md-drawer>
442+
<md-drawer #drawer1 [position]="drawer1Side"></md-drawer>
443+
<md-drawer #drawer2 [position]="drawer2Side"></md-drawer>
444444
</md-drawer-container>`,
445445
})
446446
class DrawerDynamicSide {
@@ -451,7 +451,7 @@ class DrawerDynamicSide {
451451
@Component({
452452
template: `
453453
<md-drawer-container>
454-
<md-drawer side="start" [mode]="mode">
454+
<md-drawer [position]="start" [mode]="mode">
455455
<a class="link1" href="#">link1</a>
456456
</md-drawer>
457457
<a class="link2" href="#">link2</a>

src/lib/sidenav/drawer.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export class MdDrawerToggleResult {
7979
'(keydown)': 'handleKeydown($event)',
8080
// must prevent the browser from aligning text based on value
8181
'[attr.align]': 'null',
82-
'[class.mat-drawer-end]': 'side === "end"',
82+
'[class.mat-drawer-end]': 'position === "end"',
8383
'[class.mat-drawer-over]': 'mode === "over"',
8484
'[class.mat-drawer-push]': 'mode === "push"',
8585
'[class.mat-drawer-side]': 'mode === "side"',
@@ -97,22 +97,22 @@ export class MdDrawer implements AfterContentInit, OnDestroy {
9797

9898
/** The side that the drawer is attached to. */
9999
@Input()
100-
get side() { return this._side; }
101-
set side(value) {
100+
get position() { return this._position; }
101+
set position(value) {
102102
// Make sure we have a valid value.
103103
value = value === 'end' ? 'end' : 'start';
104-
if (value != this._side) {
105-
this._side = value;
104+
if (value != this._position) {
105+
this._position = value;
106106
this.onAlignChanged.emit();
107-
this.onSideChanged.emit();
107+
this.onPositionChanged.emit();
108108
}
109109
}
110-
private _side: 'start' | 'end' = 'start';
110+
private _position: 'start' | 'end' = 'start';
111111

112112
/** @deprecated */
113113
@Input()
114-
get align() { return this.side; }
115-
set align(value) { this.side = value; }
114+
get align() { return this.position; }
115+
set align(value) { this.position = value; }
116116

117117
/** Mode of the drawer; one of 'over', 'push' or 'side'. */
118118
@Input() mode: 'over' | 'push' | 'side' = 'over';
@@ -146,7 +146,7 @@ export class MdDrawer implements AfterContentInit, OnDestroy {
146146
@Output('close') onClose = new EventEmitter<MdDrawerToggleResult | void>();
147147

148148
/** Event emitted when the drawer's side changes. */
149-
@Output('side-changed') onSideChanged = new EventEmitter<void>();
149+
@Output('side-changed') onPositionChanged = new EventEmitter<void>();
150150

151151
/** @deprecated */
152152
@Output('align-changed') onAlignChanged = new EventEmitter<void>();
@@ -395,7 +395,7 @@ export class MdDrawerContainer implements AfterContentInit {
395395
}
396396
// NOTE: We need to wait for the microtask queue to be empty before validating,
397397
// since both drawers may be swapping sides at the same time.
398-
takeUntil.call(drawer.onSideChanged, this._drawers.changes).subscribe(() =>
398+
takeUntil.call(drawer.onPositionChanged, this._drawers.changes).subscribe(() =>
399399
first.call(this._ngZone.onMicrotaskEmpty).subscribe(() => this._validateDrawers()));
400400
}
401401

@@ -414,7 +414,7 @@ export class MdDrawerContainer implements AfterContentInit {
414414

415415
// Ensure that we have at most one start and one end drawer.
416416
this._drawers.forEach(drawer => {
417-
if (drawer.side == 'end') {
417+
if (drawer.position == 'end') {
418418
if (this._end != null) {
419419
throwMdDuplicatedDrawerError('end');
420420
}

src/lib/sidenav/sidenav.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Using the `side` mode on mobile devices can affect the performance and is also n
3131
[Material Design specification](https://material.io/guidelines/patterns/navigation-drawer.html#navigation-drawer-behavior).
3232

3333
### Positioning the sidenav
34-
The `side` property determines whether the sidenav appears at the `"start"` or `"end"` of the
34+
The `position` property determines whether the sidenav appears at the `"start"` or `"end"` of the
3535
container. This is affected by the current text direction ("ltr" or "rtl"). By default, the sidenav
3636
appears at the start of the container.
3737

src/lib/sidenav/sidenav.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import {animate, state, style, transition, trigger} from '@angular/animations';
4141
'(keydown)': 'handleKeydown($event)',
4242
// must prevent the browser from aligning text based on value
4343
'[attr.align]': 'null',
44-
'[class.mat-drawer-end]': 'side === "end"',
44+
'[class.mat-drawer-end]': 'position === "end"',
4545
'[class.mat-drawer-over]': 'mode === "over"',
4646
'[class.mat-drawer-push]': 'mode === "push"',
4747
'[class.mat-drawer-side]': 'mode === "side"',

0 commit comments

Comments
 (0)