Skip to content

bug(accordion): reordering confuses expansion state of the panels #6446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
princemaple opened this issue Aug 14, 2017 · 4 comments
Closed

bug(accordion): reordering confuses expansion state of the panels #6446

princemaple opened this issue Aug 14, 2017 · 4 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@princemaple
Copy link
Contributor

princemaple commented Aug 14, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Reordering of the panels does not affect the expansion status of the panels

What is the current behavior?

It does cause some wrong behavior

What are the steps to reproduce?

http://plnkr.co/edit/F6AunHYXOfxGKID5oYV3?p=preview

image

  1. expand item 1, which is at the top and has active: false
    image

  2. toggle active, so it becomes active: true and falls down the list
    image

  3. expand item 2, which is now at the top, it will become the expanded one in the accordion, but it won't really show the expanded content
    image

What is the use-case or motivation for changing an existing behavior?

When I want to sort items by some status of them, I expect to be able to do so without running into bugs :)

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

NG 4.3.2, MD2 beta8

If I close the panel and reopen it, everything will be fine again
Not really, item 3 is also affected, somehow.

Am I not supposed to reorder accordion items, though?

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Aug 16, 2017
@crisbeto
Copy link
Member

@princemaple I'm unable to reproduce the issue in your example. Since the Plunkr is pointing to the latest Material build, it means that the issue could be fixed in master. Can you verify?

@willshowell
Copy link
Contributor

@crisbeto maybe it's related to #5743? I can't replicate the original plunker either, but the end result looks the same.

@princemaple
Copy link
Contributor Author

@crisbeto it indeed seems to be fixed on master.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants