Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

md-autocomplete not showing some suggestions #5606

Closed
wil93 opened this issue Nov 7, 2015 · 21 comments
Closed

md-autocomplete not showing some suggestions #5606

wil93 opened this issue Nov 7, 2015 · 21 comments
Assignees
Milestone

Comments

@wil93
Copy link

wil93 commented Nov 7, 2015

It worked correctly with 1.0.0-rc2:

old

Now I upgraded to 1.0.0-rc3 and it doesn't show some suggestions:

new1

After scrolling a bit, more suggestions appear:

new2

@gpopovic
Copy link

gpopovic commented Nov 7, 2015

+1

@Patrik-Lundqvist
Copy link
Contributor

Yeah, I'm having this problem too

@idoo
Copy link

idoo commented Nov 9, 2015

Temporary fix for this problem is:

.md-virtual-repeat-container.md-autocomplete-suggestions-container
  height: 120px

@hillerstorm
Copy link

Fixed by reverting 330419b

issue: #5561

How could this even get merged without checking first?
That PR in it's entirety was awful... suggestions for changes without anything being done, still gets merged.

@kseamon
Copy link
Contributor

kseamon commented Nov 9, 2015

This isn't reproducing for me on the Autocomplete demo page. Can someone post an example?

@kseamon
Copy link
Contributor

kseamon commented Nov 9, 2015

Question for those affected by this: Is your autocomplete in an ng-hide? If so, #5579 should fix it.

@hexadecy
Copy link

hexadecy commented Nov 9, 2015

1.0.0-rc3
Autocomplete > Inside Dialog
There is only 3 items displayed at a time.

@wil93
Copy link
Author

wil93 commented Nov 10, 2015

@kseamon: my autocomplete is not in an ng-hide, but it's beside one.

@NicolasBlois
Copy link

@kseamon here is a gif to reproduce. Try to resize you window and focus again on the autocomplete input.

b4672164-859c-11e5-92f9-343cc5c9fe85

@kseamon
Copy link
Contributor

kseamon commented Nov 11, 2015

@blootch Thanks - that tells me exactly what I need actually.

@kseamon
Copy link
Contributor

kseamon commented Nov 11, 2015

Ok, made a tweak to #5579 and it fixes this issue.

@thomasrye
Copy link

@idoo That temporary fix is not working for me.

@NicolasBlois
Copy link

@kseamon with pleasure. I think this issue has something to do with md-virtual-repeat.

@wil93
Copy link
Author

wil93 commented Nov 15, 2015

I confirm this is fixed in 1.0.0-rc4

@wil93 wil93 closed this as completed Nov 15, 2015
@gabguy
Copy link

gabguy commented Nov 17, 2015

The issue is still here in 1.0.0-rc4

@lillylykho
Copy link

+1
not working for me in 1.0.0-rc4

@wil93 wil93 reopened this Nov 17, 2015
@gligoran
Copy link

+1 The issue still here in 1.0.0-RC4.

@kseamon
Copy link
Contributor

kseamon commented Nov 20, 2015

I'm not seeing it in rc4. Those who are seeing it: what browser are you using? Are you just looking at the demo page, or some other page? If another page, what other libraries are you using? What version of Angular?

@kseamon kseamon modified the milestones: 1.0-rc6, 1.0-rc4 Nov 20, 2015
@gabguy
Copy link

gabguy commented Nov 22, 2015

@kseamon Go to: https://material.angularjs.org/latest/demo/autocomplete and mark the 'Simulate query for results?' checkbox.
Now search for 'California', then 'Shift'+'Home' to mark the intire word and press 'Delete', you will see the issue...

(BTW: Using Chrome)

@wil93
Copy link
Author

wil93 commented Nov 23, 2015

I managed to reproduce this (and I actually found it easier to reproduce without the "Simulate query" option).

This is what I see when I reproduce the bug:
bug

As you can see there are only 4 virtual-repeat elements, when 5 are needed.

This, instead, is what I see when I don't reproduce it (or when I reproduce it and then resize the window a bit, and "California" magically appears):
no bug

Now there are 6 elements.

@kseamon
Copy link
Contributor

kseamon commented Nov 25, 2015

Ok, this takes care of the version of the bug as described by @gabguy and @wil93. Closing, but let me know if you find yet another case of it.

@kseamon kseamon closed this as completed Nov 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests