chore(jasmine): Upgrade to jasmine 3.1.0

Update @types/jasmine to 2.8.8 as well

Author: awarecan

lib/frameworks/jasmine.js

@@ -91,13 +91,11 @@ exports.run = function(runner, specs) {
   };
 
   // Run specs in semi-random order
-  if (jasmineNodeOpts.random) {
-    jasmine.getEnv().randomizeTests(true);
+  jasmine.getEnv().randomizeTests(jasmineNodeOpts.random);
 
-    // Sets the randomization seed if randomization is turned on
-    if (jasmineNodeOpts.seed) {
-      jasmine.getEnv().seed(jasmineNodeOpts.seed);
-    }
+  // Sets the randomization seed if randomization is turned on
+  if (jasmineNodeOpts.seed) {
+    jasmine.getEnv().seed(jasmineNodeOpts.seed);
   }
 
   return runner.runTestPreparer().then(function() {

package-lock.json

@@ -18,7 +18,7 @@
     "blocking-proxy": "^1.0.0",
     "chalk": "^1.1.3",
     "glob": "^7.0.3",
-    "jasmine": "2.8.0",
+    "jasmine": "^3.1.0",
     "jasminewd2": "^2.1.0",
     "optimist": "~0.6.0",
     "q": "1.4.1",
@@ -31,7 +31,7 @@
   "devDependencies": {
     "@types/chalk": "^0.4.28",
     "@types/glob": "^5.0.29",
-    "@types/jasmine": "^2.5.47",
+    "@types/jasmine": "^2.8.8",
     "@types/jasminewd2": "^2.0.0",
     "@types/minimatch": "^2.0.28",
     "@types/minimist": "^1.1.28",

package.json

@@ -38,7 +38,7 @@ describe('local connect', function() {
   });
 
   describe('with the selenium standalone jar', function() {
-    it('should throw an error if the jar file does not work', function() {
+    describe('should throw an error if the jar file does not work', function() {
       var jarFile = '';
       beforeEach(function() {
         // add files to selenium folder
@@ -65,7 +65,6 @@ describe('local connect', function() {
           webdriver.getNewDriver();
         } catch(e) {
           errorFound = true;
-          expect(e.code).toBe(BrowserError.CODE);
         }
         expect(errorFound).toBe(true);
       });

spec/unit/driverProviders/local_test.js

@@ -65,6 +65,6 @@ describe('the Protractor runner', function() {
     var runner = new Runner(config);
     runner.run().then(function() {
       done.fail('expected error when no custom framework is defined');
-    }, done);
+    }, function() { return done(); });
   });
 });