Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

feat(helpers): create helpers module #211

Closed
jvandemo opened this issue Mar 26, 2015 · 3 comments
Closed

feat(helpers): create helpers module #211

jvandemo opened this issue Mar 26, 2015 · 3 comments

Comments

@jvandemo
Copy link
Contributor

Currently helper functions like dashCase(), 'copy(), notMatched(), forEach(), etc are defined in individual modules.

Downside

  • the helper functions cannot be unit tested directly
  • the helper functions must be redefined in unit tests that require them (e.g. dashCase() is redefined here), making it hard to maintain them

Proposal

I would suggest bundling all helper functions in a helpers module and write unit tests for them.

The module could be called helpers so you can easily import required helpers in code and unit tests:

import {helpers} from '../src/helpers';

Plan

@btford — if you agree with the proposal, I am willing to invest the time to implement this and create a PR for it. Just wanted to check with you before I go ahead and implement it.

Feel free to let me know if you want to go ahead with this.

@btford
Copy link
Contributor

btford commented Mar 26, 2015

Sounds good to me. Thanks @jvandemo!

@jvandemo
Copy link
Contributor Author

@btford — Thanks for the confirmation, I will make it happen.

I will also reference and close this issue when the PR has been created to keep things tidy.

@jvandemo
Copy link
Contributor Author

PR #212 has been created. Proposal can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants