Skip to content

Conversation

@ahmednfwela
Copy link

No description provided.

@GZGavinZhao GZGavinZhao added the enhancement New feature or request label Jun 14, 2024
@GZGavinZhao
Copy link

Current blockers, working on them one by one:

  • JSTestability needs to be migrated to staticInterop and extension types. (Mostly done, tests need to be updated)
  • Don't use tear-offs for extension methods. Not difficult to do, just annoying because we use them all over the place in tests for convenience.
  • Functions that are wrapped with toJS need to have more explicit types that follow the interop rules. This is actually a good thing because we'll then have stricter type guarantees.
  • It seems like ElementRef needs to be eliminated. (this may warrant its own issue?)

parsed.domEventName,
(event) {
(Event event) {
if (event is KeyboardEvent && parsed.matches(event)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be event.isA<KeyboardEvent>().

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isA() requires to bump SDK to 3.4.0

@GZGavinZhao GZGavinZhao changed the title feat: migrate to package:web refactor(all): migrate to package:web Jun 17, 2024
@ykmnkmi
Copy link

ykmnkmi commented Feb 10, 2025

Any news?

@dukefirehawk
Copy link

Is this migration work still going on?

@GZGavinZhao
Copy link

Unfortunately not for me as I don't have the time for this.

@ykmnkmi
Copy link

ykmnkmi commented Mar 27, 2025

@GZGavinZhao I can push this later.

@GZGavinZhao
Copy link

@ykmnkmi Thanks!

@ykmnkmi
Copy link

ykmnkmi commented Apr 16, 2025

@GZGavinZhao as new PR?

@GZGavinZhao
Copy link

@ykmnkmi That sounds good!

@ykmnkmi
Copy link

ykmnkmi commented Apr 21, 2025

@GZGavinZhao working on here.

@insinfo
Copy link

insinfo commented Nov 18, 2025

@GZGavinZhao @ykmnkmi Could you publish the ngdart 8.0.0-dev.4 version as ngdart 8.0.0 so that you can later publish version 9 migrated to package:web? I have many of my applications that directly depend on version https://pub.dev/packages/ngdart/versions/8.0.0-dev.4, which in turn depends on dart:html. In fact, I haven't migrated anything to the package:web package yet, although I should migrate something sometime next year.

@ykmnkmi
Copy link

ykmnkmi commented Nov 18, 2025

@insinfo I do not publish it. I found some problems with DOM properties. I will look into it later. +1 for web migration in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants