-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(all): migrate to package:web #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor(all): migrate to package:web #75
Conversation
Signed-off-by: Gavin Zhao <[email protected]>
Signed-off-by: Gavin Zhao <[email protected]>
Signed-off-by: Gavin Zhao <[email protected]>
|
Current blockers, working on them one by one:
|
Signed-off-by: Gavin Zhao <[email protected]>
Signed-off-by: Gavin Zhao <[email protected]>
| parsed.domEventName, | ||
| (event) { | ||
| (Event event) { | ||
| if (event is KeyboardEvent && parsed.matches(event)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be event.isA<KeyboardEvent>().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isA() requires to bump SDK to 3.4.0
|
Any news? |
|
Is this migration work still going on? |
|
Unfortunately not for me as I don't have the time for this. |
|
@GZGavinZhao I can push this later. |
|
@ykmnkmi Thanks! |
|
@GZGavinZhao as new PR? |
|
@ykmnkmi That sounds good! |
|
@GZGavinZhao working on here. |
|
@GZGavinZhao @ykmnkmi Could you publish the ngdart 8.0.0-dev.4 version as ngdart 8.0.0 so that you can later publish version 9 migrated to package:web? I have many of my applications that directly depend on version https://pub.dev/packages/ngdart/versions/8.0.0-dev.4, which in turn depends on dart:html. In fact, I haven't migrated anything to the package:web package yet, although I should migrate something sometime next year. |
|
@insinfo I do not publish it. I found some problems with DOM properties. I will look into it later. +1 for |
No description provided.